fix(android): make sdk versions configurable #2152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`compileSdkVersion`, `minSdkVersion`, `targetSdkVersion` can be configured in `gradle.properties`: ``` react.compileSdkVersion=34 react.minSdkVersion=23 react.targetSdkVersion=33 ```
Saadnajmi
approved these changes
Jul 26, 2024
Comment on lines
+4
to
+6
| compileSdkVersion = rootProject.findProperty("react.compileSdkVersion") ?: 34 | ||
| minSdkVersion = rootProject.findProperty("react.minSdkVersion") ?: 23 | ||
| targetSdkVersion = rootProject.findProperty("react.targetSdkVersion") ?: 33 |
There was a problem hiding this comment.
Nit: Save the defaults as constants? Unless you can't.
There was a problem hiding this comment.
This kinda is the file that is supposed to have all the defaults 😄
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
compileSdkVersion,minSdkVersion,targetSdkVersioncan be configured ingradle.properties:Platforms affected
Test plan
gradle.properties, try addingreact.minSdkVersion=24and build the Android app (this should succeed)gradle.properties, try addingreact.minSdkVersion=99and build the Android app (this should fail)