Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(macos): add anchor points for applicationWillFinishLaunching(_:) #2188

Merged
merged 1 commit into from
Aug 19, 2024

Conversation

tido64
Copy link
Member

@tido64 tido64 commented Aug 19, 2024

Description

Add anchor points for applicationWillFinishLaunching(_:) to make it easier for config plugin authors to target the correct override.

Platforms affected

  • Android
  • iOS
  • macOS
  • visionOS
  • Windows

Test plan

n/a

Copy link

@shirakaba shirakaba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like it'd do the trick, thanks!

@tido64 tido64 merged commit 0570c7b into trunk Aug 19, 2024
30 checks passed
@tido64 tido64 deleted the tido/macos/anchors-for-application-will-finish branch August 19, 2024 13:44
@Saadnajmi
Copy link
Collaborator

Saadnajmi commented Aug 19, 2024

@tido64 Long term, should the ifdefs be more granular? AKA, ifdefs inside the method and only one method definition?

@tido64
Copy link
Member Author

tido64 commented Aug 20, 2024

@tido64 Long term, should the ifdefs be more granular? AKA, ifdefs inside the method and only one method definition?

For AppDelegate.swift in particular, I think we want to create two more files, AppDelegate+Multi.swift and AppDelegate+Single.swift, and move the appropriate extensions to them. Single app mode requires significantly less logic to start up the app so I think what you're suggesting makes it harder to see what each mode actually implements.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
platform: macOS This affects macOS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants