Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add ability to set app version #994

Merged
merged 2 commits into from
Jul 15, 2022
Merged

feat: add ability to set app version #994

merged 2 commits into from
Jul 15, 2022

Conversation

tido64
Copy link
Member

@tido64 tido64 commented Jul 14, 2022

Description

Adds ability to set app version.

Partially resolves #990.

Platforms affected

  • Android
  • iOS
  • macOS
  • Windows

Test plan

  1. Set memorable version numbers such as:
    diff --git a/example/app.json b/example/app.json
    index ef69fa7..1173f1b 100644
    --- a/example/app.json
    +++ b/example/app.json
    @@ -2,6 +2,7 @@
       "$schema": "https://raw.githubusercontent.com/microsoft/react-native-test-app/trunk/schema.json",
       "name": "Example",
       "displayName": "Example",
    +  "version": "2.0",
       "components": [
         {
           "appKey": "Example",
    @@ -13,6 +14,15 @@
           "presentationStyle": "modal"
         }
       ],
    +  "android": {
    +    "versionCode": "9000"
    +  },
    +  "ios": {
    +    "buildNumber": "9000"
    +  },
    +  "macos": {
    +    "buildNumber": "9000"
    +  },
  2. Build Android app and verify that the version numbers are correctly set: yarn android
  3. Prepare iOS/macOS Xcode projects and verify that the version numbers are correctly set: pod install
    Screenshot 2022-07-14 at 16 03 26

@github-actions github-actions bot added platform: Android This affects Android platform: iOS This affects iOS platform: macOS This affects macOS platform: Windows This affects Windows labels Jul 14, 2022
@tido64 tido64 requested review from kelset and afoxman July 14, 2022 14:27
@tido64 tido64 merged commit 6e928e5 into trunk Jul 15, 2022
@tido64 tido64 deleted the tido/set-app-version branch July 15, 2022 07:15
@tido64 tido64 added this to the Single-app Mode milestone Jul 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
platform: Android This affects Android platform: iOS This affects iOS platform: macOS This affects macOS platform: Windows This affects Windows
Projects
None yet
Development

Successfully merging this pull request may close these issues.

mechanism to set app icon, app version
2 participants