Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fabric] Finish implementing ShadowProps for other components #11754

Closed
jonthysell opened this issue Jun 13, 2023 · 0 comments · Fixed by #12108
Closed

[Fabric] Finish implementing ShadowProps for other components #11754

jonthysell opened this issue Jun 13, 2023 · 0 comments · Fixed by #12108
Assignees
@TatianaKapos
Labels
Area: Fabric Support Facebook Fabric enhancement New Architecture Broad category for issues that apply to the RN "new" architecture of Turbo Modules + Fabric
Milestone
0.73

Comments

@jonthysell
Copy link
Contributor

Summary

Summary

While each of our composition visuals Visual supports setting the various Shadow props: shadorColor, shadowOffset, shadowOpacity, shadowRadius we only consume the incoming props for View component, within CompositionViewComponentView::updateProps().

Move the logic into a private helper within CompositionBaseComponentView and call that logic from the updateProps of the ComponentViews for Text, Image, TextInput, ScrollView, ActivityIndicator, Switch.

Motivation

Reach component property parity.

Basic Example

No response

Open Questions

No response
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs: Triage 🔍 New issue that needs to be reviewed by the issue management team (label applied by bot) label Jun 13, 2023
@chrisglein chrisglein added this to the 0.73 milestone Jun 15, 2023
@chrisglein chrisglein added Area: Fabric Support Facebook Fabric and removed Needs: Triage 🔍 New issue that needs to be reviewed by the issue management team (label applied by bot) labels Jun 15, 2023
@TatianaKapos TatianaKapos mentioned this issue Sep 5, 2023
Merged
@jonthysell jonthysell added the New Architecture Broad category for issues that apply to the RN "new" architecture of Turbo Modules + Fabric label Mar 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@TatianaKapos TatianaKapos

Labels
Area: Fabric Support Facebook Fabric enhancement New Architecture Broad category for issues that apply to the RN "new" architecture of Turbo Modules + Fabric
Projects
RNW New Architecture
Status: Done
Milestone
0.73
Development

Successfully merging a pull request may close this issue.

[Fabric] Enable ShadowProps for all Fabric Components TatianaKapos/react-native-windows
3 participants
@jonthysell @chrisglein @TatianaKapos