Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement 'role' with native implentation #11886

Closed
TatianaKapos opened this issue Jul 12, 2023 · 1 comment · Fixed by #12792
Closed

Implement 'role' with native implentation #11886

TatianaKapos opened this issue Jul 12, 2023 · 1 comment · Fixed by #12792
Labels
Area: Accessibility Area: Paper bug Integration Follow-up Old Architecture Broad category for issues that apply to the RN "old" architecture of Cxx Modules + Paper
Milestone

Comments

@TatianaKapos
Copy link
Contributor

Problem Description

Latest integration brought in Native ARIA Roles: Remove JS Shim which removes the JS shimming of role to accessibilityRole. Not sure if we already have a native implementation of role or not but their PR states "This will require any out of tree platforms to add their own native implementation for role to continue to work.". This needs further investigation!

Steps To Reproduce

  1. Launch playground and test 'role'

Expected Results

No response

CLI version

12.0.0-alpha.3

Environment

System:
  OS: Windows 10 10.0.22621
  CPU: (8) x64 Intel(R) Core(TM) i7-9700K CPU @ 3.60GHz
  Memory: 52.40 GB / 63.85 GB
Binaries:
  Node:
    version: 18.5.0
    path: C:\Program Files\nodejs\node.EXE
  Yarn:
    version: 1.22.5
    path: C:\Program Files (x86)\Yarn\bin\yarn.CMD
  npm:
    version: 8.18.0
    path: C:\Program Files\nodejs\npm.CMD
  Watchman: Not Found
SDKs:
  Android SDK: Not Found
  Windows SDK:
    AllowDevelopmentWithoutDevLicense: Enabled
    AllowAllTrustedApps: Enabled
    Versions:
      - 10.0.17763.0
      - 10.0.18362.0
      - 10.0.19041.0
      - 10.0.22000.0
IDEs:
  Android Studio: AI-213.7172.25.2113.9014738
  Visual Studio:
    - 16.11.33801.447 (Visual Studio Enterprise 2019)
    - 17.6.33801.468 (Visual Studio Enterprise 2022)
Languages:
  Java:
    version: 11.0.16.1
    path: C:\Program Files\Eclipse Adoptium\jdk-11.0.16.101-hotspot\bin\javac.EXE
  Ruby: Not Found
npmPackages:
  "@react-native-community/cli": Not Found
  react: Not Found
  react-native: Not Found
  react-native-windows: Not Found
npmGlobalPackages:
  "*react-native*": Not Found
Android:
  hermesEnabled: Not found
  newArchEnabled: Not found
iOS:
  hermesEnabled: Not found
  newArchEnabled: Not found

Target Platform Version

10.0.19041

Target Device(s)

Desktop

Visual Studio Version

Visual Studio 2022

Build Configuration

Debug

Snack, code example, screenshot, or link to a repository

No response

@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs: Triage 🔍 New issue that needs to be reviewed by the issue management team (label applied by bot) label Jul 12, 2023
@TatianaKapos TatianaKapos added Integration Follow-up and removed Needs: Triage 🔍 New issue that needs to be reviewed by the issue management team (label applied by bot) labels Jul 12, 2023
@microsoft-github-policy-service microsoft-github-policy-service bot added Invalid Triage https://github.com/microsoft/react-native-windows/wiki/Triage-Process (label applied by bot) labels Jul 13, 2023
@TatianaKapos TatianaKapos added the Needs: Triage 🔍 New issue that needs to be reviewed by the issue management team (label applied by bot) label Jul 13, 2023
@chrisglein chrisglein added Area: Accessibility and removed Needs: Triage 🔍 New issue that needs to be reviewed by the issue management team (label applied by bot) Invalid Triage https://github.com/microsoft/react-native-windows/wiki/Triage-Process (label applied by bot) labels Jul 13, 2023
@chrisglein chrisglein added this to the 0.73 milestone Jul 13, 2023
@chrisglein
Copy link
Member

Generally these xplat React changes are only targeting Fabric, but this is one that also affects Paper. So we'll need to figure out for both here.

@chiaramooney chiaramooney removed their assignment Nov 7, 2023
@jonthysell jonthysell added Area: Paper Old Architecture Broad category for issues that apply to the RN "old" architecture of Cxx Modules + Paper labels Mar 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Accessibility Area: Paper bug Integration Follow-up Old Architecture Broad category for issues that apply to the RN "old" architecture of Cxx Modules + Paper
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

4 participants