Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement autoCapitalize property for TextInput for fabric #13120

Closed
jonthysell opened this issue Apr 29, 2024 · 1 comment · Fixed by #13343
Closed

Implement autoCapitalize property for TextInput for fabric #13120

jonthysell opened this issue Apr 29, 2024 · 1 comment · Fixed by #13343
Assignees
@danielayala94
Labels
API: Completion Area: Component Views Area: Fabric Support Facebook Fabric Area: TextInput enhancement New Architecture Broad category for issues that apply to the RN "new" architecture of Turbo Modules + Fabric Parity: Fabric vs. Paper RNW Fabric does not look or behave like RNW Paper Workstream: Component Parity Close the parity gap between RNW and RN for core RN components and their supporting APIs.
Milestone
Next

Comments

@jonthysell
Copy link
Contributor

Implement the autoCapitalize property for the fabric implementation of TextInput.

Note: A commented out version of this already exists in our new fabric code and may possibly just need to be re-applied.

This property was available in RNW Paper via TextInputViewManager.

See https://reactnative.dev/docs/textinput#autocapitalize for details.
@jonthysell jonthysell added API: Completion Area: Component Views Area: Fabric Support Facebook Fabric Area: TextInput enhancement New Architecture Broad category for issues that apply to the RN "new" architecture of Turbo Modules + Fabric Parity: Fabric vs. Paper RNW Fabric does not look or behave like RNW Paper labels Apr 29, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs: Triage 🔍 New issue that needs to be reviewed by the issue management team (label applied by bot) label Apr 29, 2024
@chrisglein chrisglein added this to the Backlog milestone Apr 30, 2024
@chrisglein chrisglein removed the Needs: Triage 🔍 New issue that needs to be reviewed by the issue management team (label applied by bot) label Apr 30, 2024
@marlenecota
Copy link
Contributor

I think maybe it was commented out because it was only exposed as Android specific?

I noticed this commit in the latest integration:
facebook/react-native@7b3c622

If that's the case, you can try the commented out code after this merges: #13264

@danielayala94 danielayala94 mentioned this issue May 23, 2024
Closed
@danielayala94 danielayala94 mentioned this issue Jun 13, 2024
Merged
@chrisglein chrisglein modified the milestones: Backlog, Next Jun 19, 2024
@chiaramooney chiaramooney added the Workstream: Component Parity Close the parity gap between RNW and RN for core RN components and their supporting APIs. label Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@danielayala94 danielayala94

Labels
API: Completion Area: Component Views Area: Fabric Support Facebook Fabric Area: TextInput enhancement New Architecture Broad category for issues that apply to the RN "new" architecture of Turbo Modules + Fabric Parity: Fabric vs. Paper RNW Fabric does not look or behave like RNW Paper Workstream: Component Parity Close the parity gap between RNW and RN for core RN components and their supporting APIs.
Projects
RNW New Architecture
Status: Done
Milestone
Next
5 participants
@marlenecota @jonthysell @danielayala94 @chrisglein @chiaramooney