Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move SampleTurboModule out of core and into it's own package #13535

Open
jonthysell opened this issue Aug 5, 2024 · 0 comments
Open

Move SampleTurboModule out of core and into it's own package #13535

jonthysell opened this issue Aug 5, 2024 · 0 comments
Labels
Area: Turbo Modules enhancement New Architecture Broad category for issues that apply to the RN "new" architecture of Turbo Modules + Fabric
Milestone

Comments

@jonthysell
Copy link
Contributor

Summary

SampleTurboModule is defined in RN core, but really it's really only there to be used by the RNTester example page.

In PR #13533, we added RNW's SampleTurboModule impl in RNW core, but we have the opportunity to move it into its own package.

Motivation

So that end customers can actually use SampleTurboModule as a sample they can duplicate.

Basic Example

  1. New private package in packages/react-native-sample-turbo-module
  2. Update each of our apps that uses RNTester js (e2e-test-app, e2e-trest-app-fabric, playground, etc.) to depend on that package

Open Questions

Will it be possible for us to do this without requiring the upstream module to be moved out of core? Is this sample perhaps a good way of testing how to add platform support to a module even if you can't modify the package that contains its spec/definition?

@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs: Triage 🔍 New issue that needs to be reviewed by the issue management team (label applied by bot) label Aug 5, 2024
@marlenecota marlenecota added Area: Turbo Modules and removed Needs: Triage 🔍 New issue that needs to be reviewed by the issue management team (label applied by bot) labels Aug 8, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added the New Architecture Broad category for issues that apply to the RN "new" architecture of Turbo Modules + Fabric label Aug 8, 2024
@marlenecota marlenecota added this to the Backlog milestone Aug 8, 2024
@jonthysell jonthysell removed their assignment Aug 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Turbo Modules enhancement New Architecture Broad category for issues that apply to the RN "new" architecture of Turbo Modules + Fabric
Projects
Status: No status
Development

No branches or pull requests

2 participants