Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch Text.windows.js to use new optimized Text #13579

Closed
TatianaKapos opened this issue Aug 15, 2024 · 0 comments · Fixed by #13647
Closed

Switch Text.windows.js to use new optimized Text #13579

TatianaKapos opened this issue Aug 15, 2024 · 0 comments · Fixed by #13647

Comments

@TatianaKapos
Copy link
Contributor

Problem Description

Recent Integration switched Text.js to use new optimized TextOptimized.js and removed the gating. Previously you would need to turn on a flag to use TextOptimized and we never turned this flag on. Trying to switch it in the Integration works for Paper but breaks Text accessibility for Fabric. Further work will need to be done to switch to the optimized text.

Link to the integration where the error originated

#13554

Link to commit

https://github.com/facebook/react-native/pull/45317/files

Forked files

  1. Text.windows.js

Upstream PR

N/A

Build Configuration

Debug

@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs: Triage 🔍 New issue that needs to be reviewed by the issue management team (label applied by bot) label Aug 15, 2024
@TatianaKapos TatianaKapos changed the title Switch Text.windows.js and Text.win32.js to use new optimized Text Switch Text.windows.js to use new optimized Text Aug 15, 2024
@chiaramooney chiaramooney added this to the Backlog milestone Aug 19, 2024
@chiaramooney chiaramooney added enhancement API: Completion and removed Needs: Triage 🔍 New issue that needs to be reviewed by the issue management team (label applied by bot) labels Aug 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants