Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Fork of LayoutableShadowNode.cpp #13644

Open
chiaramooney opened this issue Sep 3, 2024 · 2 comments
Open

Remove Fork of LayoutableShadowNode.cpp #13644

chiaramooney opened this issue Sep 3, 2024 · 2 comments
Assignees
@marlenecota
Labels
enhancement Integration Follow-up Workstream: Releases and Integrations Keep RNW current with RN releases.
Milestone
Next

Comments

@chiaramooney
Copy link
Contributor

chiaramooney commented Sep 3, 2024 •
edited by marlenecota
Loading

Problem Description

Error: Could not convert type to float. Patch added to file to cast value to float type.

Link to the integration where the error originated

#13627

Link to commit

facebook/react-native@1d1646a

Forked files

  1. LayoutableShadowNode.cpp

Upstream PR

original PR: facebook/react-native#46315
new PR: facebook/react-native#46447

Build Configuration

Debug
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs: Triage 🔍 New issue that needs to be reviewed by the issue management team (label applied by bot) label Sep 3, 2024
@chiaramooney
Copy link
Contributor Author

Upstream PR merged. These forks can be removed after 9/4 is integrated.

@jonthysell jonthysell added this to the Next milestone Sep 5, 2024
@jonthysell jonthysell added bug enhancement and removed Needs: Triage 🔍 New issue that needs to be reviewed by the issue management team (label applied by bot) bug labels Sep 5, 2024
@marlenecota marlenecota mentioned this issue Sep 9, 2024
Merged
@marlenecota
Copy link
Contributor

marlenecota commented Sep 11, 2024 •
edited
Loading

Attempted to remove this fork in the 9/9 integration, but it looks like the fix wasn't quite right. Created a new PR and added it to this bug.

Update: Upstream PR merged. File can be unforked with the 9/12 integration.

@marlenecota marlenecota self-assigned this Sep 12, 2024
@chiaramooney chiaramooney added the Workstream: Releases and Integrations Keep RNW current with RN releases. label Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@marlenecota marlenecota

Labels
enhancement Integration Follow-up Workstream: Releases and Integrations Keep RNW current with RN releases.
Projects
None yet
Milestone
Next
Development

No branches or pull requests
3 participants
@marlenecota @jonthysell @chiaramooney