Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update comments in app.windows.bundle with correct cli command #2451

Closed
3 tasks
marlenecota opened this issue May 10, 2019 · 5 comments
Closed
3 tasks

Update comments in app.windows.bundle with correct cli command #2451

marlenecota opened this issue May 10, 2019 · 5 comments
Assignees
@marlenecota
Labels
Documentation
Milestone
IGNITE (vNext M3)

Comments

@marlenecota
Copy link
Contributor

The file currently mentions "--platform windows" which is not valid. It also has inconsistent naming (app.windows.js vs index.windows.bundle)

  • Update platform listed in comment
  • Fix inconsistent naming
  • Add bundle script to package.json
@marlenecota marlenecota self-assigned this May 10, 2019
@ghost ghost added the Needs: Triage 🔍 New issue that needs to be reviewed by the issue management team (label applied by bot) label May 10, 2019
@kmelmon kmelmon removed the Needs: Triage 🔍 New issue that needs to be reviewed by the issue management team (label applied by bot) label May 14, 2019
@kmelmon kmelmon added this to the vNext Milestone 3 milestone May 14, 2019
@kmelmon
Copy link
Contributor

kmelmon commented May 14, 2019

@marlenecota can you clarify what's needed here, and if a CLI update is needed, enlist Margaryta's help in getting the CLI updated?

@marlenecota
Copy link
Contributor Author

The only CLI changes happening are documentation.

https://github.com/microsoft/react-native-windows/blob/master/vnext/local-cli/generator-windows/templates/app.windows.bundle

That file has instructions on how to generate a bundle, but they weren't updated after the platform and some files were renamed.

@kmelmon
Copy link
Contributor

kmelmon commented May 15, 2019

gotcha thanks - I'll leave this assigned to you then.

@ruslan-bikkinin ruslan-bikkinin mentioned this issue May 16, 2019
Closed
8 tasks
@kmelmon kmelmon assigned marlenecota and unassigned in4margaret Jul 5, 2019
@kmelmon
Copy link
Contributor

kmelmon commented Jul 5, 2019

margaryta seems to have other priorities nowadays, reassigning this to marlene

@marlenecota
Copy link
Contributor Author

Fixed by #3099

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@marlenecota marlenecota

Labels
Documentation
Projects
None yet
Milestone
IGNITE (vNext M3)
Development

No branches or pull requests
5 participants
@marlenecota @in4margaret @harinikmsft @chrisglein @kmelmon