Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement the receiving of events for EventAnimationDriver #2941

Closed
StephenLPeters opened this issue Aug 15, 2019 · 2 comments
Closed

Implement the receiving of events for EventAnimationDriver #2941

StephenLPeters opened this issue Aug 15, 2019 · 2 comments
Labels
API: Completion Area: Animation enhancement Partner: Facebook Partner: Stream (label may be applied by bot based on author)
Milestone
Backlog

Comments

@StephenLPeters
Copy link
Contributor

The NativeAnimationModule does not properly receive events when making an EventAnimationDriver.

The Naive solution that is implemented by current and andriod implementations involves quite a bit of use of the bridge as the event is raised by the target competent, and then tunneled back to the native side. We could bypass this exchange, and in some cases remove the need to rely on the UI thread for the event by having shadow nodes declare how to route these events.

Regardless, one of these implementations is needed to complete the NativeAnimationModule.
@StephenLPeters StephenLPeters self-assigned this Aug 15, 2019
@ghost ghost added the Needs: Triage 🔍 New issue that needs to be reviewed by the issue management team (label applied by bot) label Aug 15, 2019
@chrisglein chrisglein added this to the vNext Milestone 3 milestone Aug 24, 2019
@chrisglein chrisglein removed the Needs: Triage 🔍 New issue that needs to be reviewed by the issue management team (label applied by bot) label Aug 26, 2019
@asklar asklar removed their assignment Nov 4, 2019
@ddalp ddalp mentioned this issue Nov 14, 2019
Closed
@chrisglein chrisglein mentioned this issue Mar 16, 2020
Open
@chrisglein chrisglein added the Partner: Stream (label may be applied by bot based on author) label Mar 16, 2020
@chrisglein
Copy link
Member

Linking back to Stephen's native animated module doc: https://github.com/microsoft/react-native-windows/wiki/NativeAnimatedModule

@chrisglein chrisglein modified the milestones: 0.62 (M5), Backlog Apr 10, 2020
@ghost ghost added the Invalid Triage https://github.com/microsoft/react-native-windows/wiki/Triage-Process (label applied by bot) label Sep 16, 2020
@chrisglein chrisglein added API: Completion enhancement and removed Invalid Triage https://github.com/microsoft/react-native-windows/wiki/Triage-Process (label applied by bot) labels Sep 25, 2020
@chrisglein chrisglein mentioned this issue Oct 20, 2020
Closed
@chrisglein
Copy link
Member

Not something we plan to address on the Paper renderer as we move towards Fabric.
Fabric API completion is tracked here: #11135

@chrisglein chrisglein closed this as not planned Won't fix, can't repro, duplicate, stale Aug 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
API: Completion Area: Animation enhancement Partner: Facebook Partner: Stream (label may be applied by bot based on author)
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
4 participants
@rozele @StephenLPeters @asklar @chrisglein