Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

View removeClippedSubviews #3067

Closed
chrisglein opened this issue Sep 4, 2019 · 2 comments
Closed

View removeClippedSubviews #3067

chrisglein opened this issue Sep 4, 2019 · 2 comments
Labels
API: Completion Area: ScrollView enhancement Recommend: Not Planned Recommend that issue should be given Not Planned milestone.
Milestone
Backlog

Comments

@chrisglein
Copy link
Member

chrisglein commented Sep 4, 2019 •
edited
Loading

Split out from #2113
Experimental: When true, offscreen child views (whose overflow value is hidden) are removed from their native backing superview when offscreen. This can improve scrolling performance on long lists. The default value is true.
Not directly supported by ScrollViewer. Seems difficult. Needs deep dive.
@ghost ghost added the Needs: Triage 🔍 New issue that needs to be reviewed by the issue management team (label applied by bot) label Sep 4, 2019
@chrisglein chrisglein added API: Completion Area: ScrollView must-have p1 and removed Needs: Triage 🔍 New issue that needs to be reviewed by the issue management team (label applied by bot) labels Sep 4, 2019
@chrisglein chrisglein added this to the vNext Milestone 3 milestone Sep 4, 2019
@kikisaints kikisaints mentioned this issue Sep 4, 2019
Closed
23 tasks
@marlenecota marlenecota changed the title removeClippedSubviews ScrollView removeClippedSubviews Oct 31, 2019
@chrisglein chrisglein removed the vnext label Mar 18, 2020
@chrisglein chrisglein modified the milestones: 0.62 (M5), Backlog Apr 9, 2020
@ghost ghost added the Invalid Triage https://github.com/microsoft/react-native-windows/wiki/Triage-Process (label applied by bot) label Sep 16, 2020
@chrisglein chrisglein added enhancement and removed Invalid Triage https://github.com/microsoft/react-native-windows/wiki/Triage-Process (label applied by bot) labels Sep 23, 2020
@NickGerleman
Copy link
Collaborator

This now seems to be on View itself, and not experimental. New description at https://reactnative.dev/docs/view#removeclippedsubviews

This is a reserved performance property exposed by RCTView and is useful for scrolling content when there are many subviews, most of which are offscreen. For this property to be effective, it must be applied to a view that contains many subviews that extend outside its bound. The subviews must also have overflow: hidden, as should the containing view (or one of its superviews).

@NickGerleman NickGerleman changed the title ScrollView removeClippedSubviews View removeClippedSubviews Sep 25, 2020
@chrisglein chrisglein added the Recommend: Not Planned Recommend that issue should be given Not Planned milestone. label Aug 30, 2023
@chrisglein
Copy link
Member Author

Not something we plan to address on the Paper renderer as we move towards Fabric.
Fabric API completion for 'View' is tracked here: #11136 (and is completed for Fabric)

@chrisglein chrisglein closed this as not planned Won't fix, can't repro, duplicate, stale Sep 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
API: Completion Area: ScrollView enhancement Recommend: Not Planned Recommend that issue should be given Not Planned milestone.
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
2 participants
@NickGerleman @chrisglein