-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable access to the developer menu through NativeModules.DevMenu from within the RNW app context #3822
Comments
@SounD120 Thanks for looking into this! We do support the developer menu but it looks like we missed the native module access. We'll fill this gap. |
I'd kind of expect this functionality in VSCode to be implemented with the metro websocket, rather than directly calling into the NativeModule in the app's JS Context... I give some code pointers on how that works in this issue on the react-native-mac repo: microsoft/react-native-macos#310 |
@TheSavior I've read your comment on the macOS issue. I understand Flipper handles the dev menu through Metro. Still, can you tell me why you'd object to exposing the it in NativeModule for the purposes of this task? |
I think it’s fine to expose that native module since it exists in iOS. My comment was less about that and more a comment about the implementation chosen for the vscode plugin 😀 |
@SounD120 FYI I'm starting to look into this. |
Half of the issue is now resolved - we've introduced the DevSettings module, which exposes the Reload() method. |
As @rectified95 said, the native module exists now. I'm curious about the mechanism being used on iOS. Does that work when doing direct debugging with hermes? Also windows supports the metro command too, so just hitting 'd' in the metro window will also cause RNW to show the debug menu. -- I suspect that flipper is using the metro command - as the show debug menu button in flipper works in RNW too. |
Hello, I am from React Native Tools VS Code extension developement team. In the extension we have special command palette commands to reload the attached app and to show React Native Developer Menu in it. In RN Android we do that via adb commands, in iRN OS we do that via
require('NativeModules').DevMenu.show()
andrequire('NativeModules').DevMenu.reload()
during debugging, but in React Native for Windows0.60.0-vnext.105
there is noDevMenu
in theNativeModules
list.So we'd like to ask if the team plans to implement access to the
DevMenu
from theNativeModules
package, or maybe there are some other alternatives for programmatically accessing Developer Menu during debugging?The text was updated successfully, but these errors were encountered: