Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove usage of DisplayInformation GetForCurrentView #5474

Closed
Tracked by #9393
asklar opened this issue Jul 9, 2020 · 4 comments
Closed
Tracked by #9393

Remove usage of DisplayInformation GetForCurrentView #5474

asklar opened this issue Jul 9, 2020 · 4 comments
Labels
Area: Islands enhancement
Milestone
Not Planned Work

Comments

@asklar
Copy link
Member

asklar commented Jul 9, 2020

Islands / winui 3 won't work well with DisplayInformation.GetForCurrentView , so we need to instead use something like XamlRoot.RasterizationScale and XamlRoot.Size, and listen to events from XamlRoot.Changed
@asklar asklar added the bug label Jul 9, 2020
@ghost ghost added the Needs: Triage 🔍 New issue that needs to be reviewed by the issue management team (label applied by bot) label Jul 9, 2020
@chrisglein
Copy link
Member

APIs will only exist where islands are, like 19H1+ or WinUI3.
Some concerns raised here about multiple window/screen scenarios.
These are WinRT APIs, not WinUI APIs. Maybe addressed with Reunion?
We've raised these topics before, need to find the links.

@chrisglein chrisglein removed the Needs: Triage 🔍 New issue that needs to be reviewed by the issue management team (label applied by bot) label Jul 9, 2020
@chrisglein chrisglein added this to the Backlog milestone Jul 9, 2020
@chrisglein
Copy link
Member

Related issues: #4002 #3567

@asklar
Copy link
Member Author

asklar commented Jul 17, 2020

Reunion: microsoft/WindowsAppSDK#114

@chrisglein chrisglein mentioned this issue Jan 18, 2022
Closed
10 tasks
@chiaramooney
Copy link
Contributor

Not something we plan to address on the Paper renderer as we move towards Fabric.
This behavior should be different on the non-XAML Fabric renderer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area: Islands enhancement
Projects
Re-target onto Windows App SDK
Status: Complete
Milestone
Not Planned Work
Development

No branches or pull requests
3 participants
@asklar @chrisglein @chiaramooney