Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow --useWinUI3 and --experimentalNugetDependency to be used together in CLI #9112

Closed
AgneLukoseviciute opened this issue Nov 11, 2021 · 4 comments
Labels
Area: CLI Area: WinUI enhancement Platform: WinAppSDK PR Follow-up Issue created in response to PR Feedback (labeled so we can gather telemetry on follow-up) Recommend: Not Planned Recommend that issue should be given Not Planned milestone.
Milestone

Comments

@AgneLukoseviciute
Copy link
Contributor

AgneLukoseviciute commented Nov 11, 2021

Summary

See #9099. Once WinAppSDK support is added in, we'll want to allow using these two flags simultaneously.

Motivation

Revert #5297 once it's no longer applicable.

@ghost ghost added the Needs: Triage 🔍 New issue that needs to be reviewed by the issue management team (label applied by bot) label Nov 11, 2021
@AgneLukoseviciute
Copy link
Contributor Author

The latest version of the the CLI runs for all new projects, even against older RNW versions. Even if you can use both flags now for new projects, I don't think it will be true for older RNW versions.

yes actually @jonthysell has a good point - we would have to do a version check or something in the CLI to only allow certain versions. Really the CLI should delegate project creation logic to some version-specific package/code (we have an issue filed about syncing command line options)

Originally posted by @asklar in #9099 (comment)

@chrisglein chrisglein added Area: CLI PR Follow-up Issue created in response to PR Feedback (labeled so we can gather telemetry on follow-up) Area: WinUI labels Nov 11, 2021
@chrisglein chrisglein added this to the 0.68 milestone Nov 11, 2021
@chrisglein
Copy link
Member

One solution here may be that if you useWinUI3 that you only use the nuget (AKA we don't have the ability to build by source while also targeting WinUI3).

@chrisglein chrisglein removed the Needs: Triage 🔍 New issue that needs to be reviewed by the issue management team (label applied by bot) label Nov 15, 2021
@chrisglein chrisglein modified the milestones: 0.68, 0.69 Feb 18, 2022
@jonthysell
Copy link
Contributor

@AgneLukoseviciute Is this still something that makes sense for 0.69 or should it be moved to 0.70?

@AgneLukoseviciute AgneLukoseviciute modified the milestones: 0.69, 0.70 May 10, 2022
@chrisglein chrisglein modified the milestones: 0.70, Backlog Jul 18, 2022
@rtorr
Copy link

rtorr commented Nov 1, 2022

Is this no longer relevant or is there still a plan for this?

@marlenecota marlenecota added the Recommend: Not Planned Recommend that issue should be given Not Planned milestone. label Aug 29, 2023
@chrisglein chrisglein closed this as not planned Won't fix, can't repro, duplicate, stale Sep 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: CLI Area: WinUI enhancement Platform: WinAppSDK PR Follow-up Issue created in response to PR Feedback (labeled so we can gather telemetry on follow-up) Recommend: Not Planned Recommend that issue should be given Not Planned milestone.
Projects
Development

No branches or pull requests

5 participants