Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependency config needs a nugetPackageLang field for nugetPackage objects #9576

Open
Tracked by #7227
jonthysell opened this issue Feb 19, 2022 · 2 comments
Open
Tracked by #7227
Labels
Area: Autolinking Area: Native Modules enhancement Workstream: New Arch NuGet Refactor Create new architecture NuGet packages that exclude old architecture types and dependencies.
Milestone

Comments

@jonthysell
Copy link
Contributor

jonthysell commented Feb 19, 2022

Summary

Dependency config needs a nugetPackageLang field for nugetPackage objects (and should be verifying all required fields are present)

  • nugetPackage object needs to specify every field manually in react-native.config.js that will be needed by autolinking
    • packageName and packageVersion should be obvious
    • cppHeaders, cppPackageProviders, csNamespaces, csPackageProviders should be that same as the above (though they should allow empty arrays)
    • Need to add nugetPackageLang to help make sure we can specify ConsumeCSharpModules correctly for C++ apps
  • Config should verify that all fields are present if there are any nugetPackage objects in the react-native.config.js
  • Dependency config tests should be added which verify that specifying these items (correctly and incorrectly) creates the correct config output

Motivation

We want to support community modules that are distributed as nuget packages, so we need to know how to handle them in RNW apps

Basic Example

No response

Open Questions

No response

@ghost ghost added the Needs: Triage 🔍 New issue that needs to be reviewed by the issue management team (label applied by bot) label Feb 19, 2022
@jonthysell
Copy link
Contributor Author

Related task to update documentation: microsoft/react-native-windows-samples#645

@jonthysell
Copy link
Contributor Author

Part of #7227

@chrisglein chrisglein added Area: Autolinking Area: Native Modules and removed Needs: Triage 🔍 New issue that needs to be reviewed by the issue management team (label applied by bot) labels Feb 23, 2022
@chrisglein chrisglein added this to the Backlog milestone Feb 23, 2022
@chiaramooney chiaramooney added the Workstream: New Arch NuGet Refactor Create new architecture NuGet packages that exclude old architecture types and dependencies. label Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Autolinking Area: Native Modules enhancement Workstream: New Arch NuGet Refactor Create new architecture NuGet packages that exclude old architecture types and dependencies.
Projects
None yet
Development

No branches or pull requests

4 participants