Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] font-variant-numeric Alignment for numbers in tables #1093

Open
fbartho opened this issue May 21, 2019 · 2 comments
Open

[Feature] font-variant-numeric Alignment for numbers in tables #1093

fbartho opened this issue May 21, 2019 · 2 comments
Assignees

Comments

@fbartho
Copy link
Contributor

fbartho commented May 21, 2019

I've tested that this indeed works, for iOS/react-native. Specifically:

<RX.Text style={ { fontVariant: ["tabular-mums"] } as any }>

How would one go about writing the ReactXP Stylesheet support for this?

@erictraut
Copy link
Contributor

If this is supported in a compatible manner on browsers and RN, then it makes sense to add it to ReactXP. Are you interested in making a contribution?

I presume this attribute would apply to Text and Link. What about TextInput? The answer to that question determines where it should be added.

Since the HTML attribute name differs ("font-variant-numeric" versus "font-variant"), there will need to be some translation logic added to the web Styles.ts code. There are several other cases where we need to do similar translations, so that should be straightforward.

If you implement this, please make sure to do so for web and RN paths, add to the documentation, and add to the RXPTest app (which acts as our unit tests for all features).

@fbartho
Copy link
Contributor Author

fbartho commented Aug 9, 2020

I am indeed interested in contributing this feature. I will take a look at Styles.ts!

@fbartho fbartho added this to the 2.1.0 or 3.0.0 milestone Aug 9, 2020
@fbartho fbartho self-assigned this Aug 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants