Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[rush] pnpmfile doesn't work with pnpm >=6 #2764

Closed
egmacke opened this issue Jun 21, 2021 · 1 comment
Closed

[rush] pnpmfile doesn't work with pnpm >=6 #2764

egmacke opened this issue Jun 21, 2021 · 1 comment

Comments

@egmacke
Copy link
Contributor

egmacke commented Jun 21, 2021

Summary

The pnpmfile was changed when pnpm moved from v5.x.x to v6+. It moved from pnpmfile.js to .pnpmfile.cjs

This change does not seem to have been picked up by rush.

What were you trying to accomplish?

To fix a broken transitive dependency version.

What action did you perform that ran into trouble?

rush install

What went wrong?

The pnpm file never got run.

Repro steps

Repro repo: https://github.com/egmacke/rush-example

Check out the repo, and run rush install or rush update (include the --purge flag to run again)

Expected result: readPackage: Expect to see this for every package to be printed for every package being resolved.

Actual result: No output from pnpmfile readPackage

Details

What do you think is the cause of this problem?

The move by pnpm to rename the pnpmfile.js to .pnpmfile.cjs

How do you think we should fix this?

This can be manually fixed for a single run (until a rush purge) by copying/moving the common/temp/pnpmfile.js to common/temp/.pnpmfile.cjs and running rush update --full
--------------------------------------------------------------------------->

Standard questions

Please answer these questions to help us investigate your issue more quickly:

Question Answer
@microsoft/rush globally installed version? 5.42.3
rushVersion from rush.json? 5.42.3
useWorkspaces from rush.json? true
Operating system? Linux
Would you consider contributing a PR? Yes
Node.js version (node -v)? 14.15.1
@egmacke
Copy link
Contributor Author

egmacke commented Jun 21, 2021

Closing as already been fixed recentl;y (fixed by v5.47.0)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant