Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[rush] Add shamefully-hoist to pnpm options #3569

Closed
glopezep opened this issue Aug 3, 2022 · 4 comments
Closed

[rush] Add shamefully-hoist to pnpm options #3569

glopezep opened this issue Aug 3, 2022 · 4 comments

Comments

@glopezep
Copy link

glopezep commented Aug 3, 2022

Summary

Just add shamefully-hoist option when run pnpm install, it's required for some packages

Repro steps

Expected result:

Actual result:

Details

Standard questions

Please answer these questions to help us investigate your issue more quickly:

Question Answer
@microsoft/rush globally installed version?
rushVersion from rush.json?
useWorkspaces from rush.json?
Operating system?
Would you consider contributing a PR?
Node.js version (node -v)?
@iclanton
Copy link
Member

iclanton commented Aug 3, 2022

This would break the standboxing behavior of PNPM if we added it by default. If you need this for your repo, you can set this option in your .npmrc: https://pnpm.io/npmrc#shamefully-hoist. Keep in mind that this may cause unexpected behavior and effectively disables PNPMs package isolation system.

@iclanton iclanton closed this as completed Aug 3, 2022
@glopezep
Copy link
Author

glopezep commented Aug 3, 2022

@iclanton for some reason when using .npmrc it doesn't work

@octogonz
Copy link
Collaborator

octogonz commented Aug 4, 2022

@glopezep Hoisting is a quick hack that can solve some problems. But in a large monorepo, hoisting causes much worse trouble -- it is best to fix the root cause using proper methods such as pnpmfile.cjs. See #3542 and specifically #3542 (comment) for a narrowly applied version of hoisting that would minimize some of the trouble.

@octogonz
Copy link
Collaborator

octogonz commented Aug 4, 2022

for some reason when using .npmrc it doesn't work

You have to use common/config/rush/.npmrc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants