[rush] Remove node-fetch. #5031
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iclanton
requested review from
octogonz,
apostolisms,
D4N14L,
dmichon-msft and
patmill
as code owners
iclanton
force-pushed
the
remove-node-fetch
branch
from
d0acb68 to
17d3d48
Compare
D4N14L
approved these changes
Dec 9, 2024
D4N14L
reviewed
Dec 9, 2024
D4N14L
approved these changes
Dec 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Should address #5008.
This PR replaces
node-fetchwith code that uses the built-in NodeJShttpandhttpsmodules.Details
Why not upgrade
node-fetch?node-fetch@3now ships as an ESM module, which is incompatible with the way Rush is currently shipped.Right now, this loads response objects fully into memory before resolving. It may be worth changing that.
How it was tested
Published as
5.144.0-pr5031.0.Impacted documentation
None.