From a388adf50abe61124b4b5362773d582c085363da Mon Sep 17 00:00:00 2001 From: "D. Cheatham" <7143383+dcheatha@users.noreply.github.com> Date: Wed, 18 Nov 2020 10:02:53 -0800 Subject: [PATCH] Fix close button not using the tab's text color (#8046) (#8209) ## Summary of the Pull Request This sets the tab close button color to match the tab text color. ## References #8046 ## PR Checklist * [x] Closes #8046 * [x] CLA signed. If not, go over [here](https://cla.opensource.microsoft.com/microsoft/Terminal) and sign the CLA * [ ] I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: #8046 ## Detailed Description of the Pull Request / Additional comments This sets the tab close button color to match the tab text color. ## Validation Steps Performed Test light theme white tab mouse hover effect: ![Screenshot_2020-11-07_152110_3](https://user-images.githubusercontent.com/7143383/98640319-ec735e80-22de-11eb-8d35-08188405b566.png) Test dark theme white tab mouse hover effect: ![Screenshot_2020-11-07_153021_2](https://user-images.githubusercontent.com/7143383/98640377-f006e580-22de-11eb-9bb5-dde9fe9b81b6.png) (cherry picked from commit 2a340802dcd917dca1c50743da02ad8d4ee308cd) --- src/cascadia/TerminalApp/TerminalTab.cpp | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/cascadia/TerminalApp/TerminalTab.cpp b/src/cascadia/TerminalApp/TerminalTab.cpp index 567d48a7ba1..daa268e2f3a 100644 --- a/src/cascadia/TerminalApp/TerminalTab.cpp +++ b/src/cascadia/TerminalApp/TerminalTab.cpp @@ -855,6 +855,8 @@ namespace winrt::TerminalApp::implementation TabViewItem().Resources().Insert(winrt::box_value(L"TabViewItemHeaderForegroundPointerOver"), fontBrush); TabViewItem().Resources().Insert(winrt::box_value(L"TabViewItemHeaderForegroundPressed"), fontBrush); TabViewItem().Resources().Insert(winrt::box_value(L"TabViewButtonForegroundActiveTab"), fontBrush); + TabViewItem().Resources().Insert(winrt::box_value(L"TabViewButtonForegroundPressed"), fontBrush); + TabViewItem().Resources().Insert(winrt::box_value(L"TabViewButtonForegroundPointerOver"), fontBrush); _RefreshVisualState();