From bcc2ca04fc14f39f37849b4bd837ad6cdb4cdaaa Mon Sep 17 00:00:00 2001 From: Mike Griese Date: Thu, 27 Jan 2022 17:09:05 -0600 Subject: [PATCH] fixes #12276 --- src/cascadia/TerminalSettingsModel/JsonUtils.h | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/cascadia/TerminalSettingsModel/JsonUtils.h b/src/cascadia/TerminalSettingsModel/JsonUtils.h index ceb47069311..2e7a4a0e4f0 100644 --- a/src/cascadia/TerminalSettingsModel/JsonUtils.h +++ b/src/cascadia/TerminalSettingsModel/JsonUtils.h @@ -314,7 +314,10 @@ namespace Microsoft::Terminal::Settings::Model::JsonUtils val.push_back(trait.FromJson(element)); } } - else + // If the value was null, then we want to accept the value, with an + // empty array, not an array with a single empty string in it. + // See GH#12276 + else if (!json.isNull()) { val.push_back(trait.FromJson(json)); }