diff --git a/src/cascadia/TerminalApp/TasksPaneContent.cpp b/src/cascadia/TerminalApp/TasksPaneContent.cpp index cb1ed1c09e6..1724463e0c4 100644 --- a/src/cascadia/TerminalApp/TasksPaneContent.cpp +++ b/src/cascadia/TerminalApp/TasksPaneContent.cpp @@ -40,7 +40,6 @@ namespace winrt::TerminalApp::implementation // UpdateSettings(settings); } - MUX::Controls::TreeViewNode _buildTreeViewNode(const Model::Command& task) { MUX::Controls::TreeViewNode item{}; @@ -74,22 +73,6 @@ namespace winrt::TerminalApp::implementation _treeView().ItemsSource(itemSource); } - void TasksPaneContent::_containerContentChanging( - const Windows::UI::Xaml::Controls::ListViewBase& /*sender*/, - const Windows::UI::Xaml::Controls::ContainerContentChangingEventArgs& args) - { - const auto itemContainer = args.ItemContainer(); - if (args.InRecycleQueue() && itemContainer && itemContainer.ContentTemplate()) - { - // _listViewItemsCache[itemContainer.ContentTemplate()].insert(itemContainer); - itemContainer.DataContext(nullptr); - } - else - { - itemContainer.DataContext(args.Item()); - } - } - winrt::Windows::UI::Xaml::FrameworkElement TasksPaneContent::GetRoot() { return *this; diff --git a/src/cascadia/TerminalApp/TasksPaneContent.h b/src/cascadia/TerminalApp/TasksPaneContent.h index 10d4e780b39..38ff39d375b 100644 --- a/src/cascadia/TerminalApp/TasksPaneContent.h +++ b/src/cascadia/TerminalApp/TasksPaneContent.h @@ -39,11 +39,6 @@ namespace winrt::TerminalApp::implementation private: friend struct TasksPaneContentT; // for Xaml to bind events - - // winrt::Windows::UI::Xaml::Controls::Grid _root{ nullptr }; - // winrt::Microsoft::UI::Xaml::Controls::TreeView _treeView{ nullptr }; - - void _containerContentChanging(const Windows::UI::Xaml::Controls::ListViewBase& sender, const Windows::UI::Xaml::Controls::ContainerContentChangingEventArgs& args); }; struct TaskViewModel : TaskViewModelT @@ -51,6 +46,7 @@ namespace winrt::TerminalApp::implementation TaskViewModel(const winrt::Microsoft::Terminal::Settings::Model::Command& command) : _command{ command } { + // The Children() method must always return a non-null vector _children = winrt::single_threaded_observable_vector(); if (_command.HasNestedCommands()) { diff --git a/src/cascadia/TerminalApp/TasksPaneContent.xaml b/src/cascadia/TerminalApp/TasksPaneContent.xaml index d5343257adb..00519893a11 100644 --- a/src/cascadia/TerminalApp/TasksPaneContent.xaml +++ b/src/cascadia/TerminalApp/TasksPaneContent.xaml @@ -32,7 +32,8 @@ - + @@ -56,6 +57,12 @@ VerticalAlignment="Center" HorizontalAlignment="Center" Fill="{ThemeResource SystemControlBackgroundBaseMediumBrush}"/>--> + + Text="{x:Bind Input}" + Visibility="{Binding ElementName=rootItem, Path=IsSelected}" /> - + @@ -87,11 +95,11 @@ + Margin="8" + PlaceholderText="Filter tasks..." />