Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VT Passthrough enhancements beyond the FHL #10001

Open
7 of 16 tasks
zadjii-msft opened this issue Apr 29, 2021 · 0 comments
Open
7 of 16 tasks

VT Passthrough enhancements beyond the FHL #10001

zadjii-msft opened this issue Apr 29, 2021 · 0 comments
Assignees
Labels
Area-VT Virtual Terminal sequence support Issue-Scenario Product-Conhost For issues in the Console codebase
Milestone

Comments

@zadjii-msft
Copy link
Member

zadjii-msft commented Apr 29, 2021

Claimed by @miniksa.

See also:

This issue represents the follow-on items from #11264. It's a bunch of known issues from the PR that will be required to make the VT passthrough more robust.

It is not all-encompassing and resolving all of these will not necessarily be the end (and therefore not necessarily the satisfactory completion of #1173).

Conhost-side issues:

  • Peek/Read console input should probably only synchronize the cursor during cooked mode
  • Fill output character is converting WC2MB way too many times but it works
  • (also VtEngine::_WriteFill could do with a REP command which is I think a VT thing too)
  • GetConsoleCursorInfo could probably work but we'd have to pipe through a bunch of stuff
  • GetConsoleScreenBufferInfoEx is... just some data. But it's probably not correct.
  • Popups erase stuff behind them which is gonna be gross...
  • Scroll could just be DECCRA implemented in Terminal
  • WriteConsoleOutput should probably trim to the buffer size
  • ReadConsoleOutput likely needs some sort of trim as well
  • Console Title might be able to resolve a more complete answer (either by asking the host or spying on the VT going by or parallel running commands locally... idk)
  • Reconcile inheriting the cursor on PTY startup with the Looking For DSR methods (a.k.a. should we always set up the DSR watcher every time the cursor query command is called? See [FHL] Make VTApiRoutines, which does VT translation for output #11264 (comment) for details)
  • Reconcile how many times we copy the API routines into the message packet. Do we really need to do it on every message? [FHL] Make VTApiRoutines, which does VT translation for output #11264 (comment)

Terminal-side

Broadly, the Terminal doesn't actually support that many VT sequences. We'll likely run into issues immediately...

@zadjii-msft zadjii-msft added the ⛺ Reserved For future use label Apr 29, 2021
@miniksa miniksa added Area-VT Virtual Terminal sequence support Issue-Task It's a feature request, but it doesn't really need a major design. Product-Conhost For issues in the Console codebase and removed ⛺ Reserved For future use labels Jan 13, 2022
@miniksa miniksa self-assigned this Jan 13, 2022
@miniksa miniksa changed the title <reserved> VT Passthrough enhancements beyond the FHL Jan 13, 2022
@zadjii-msft zadjii-msft added Issue-Scenario and removed Issue-Task It's a feature request, but it doesn't really need a major design. labels Jan 13, 2022
@zadjii-msft zadjii-msft added this to the Megathreads milestone Jan 13, 2022
@miniksa miniksa removed their assignment Mar 31, 2022
@lhecker lhecker self-assigned this Jul 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-VT Virtual Terminal sequence support Issue-Scenario Product-Conhost For issues in the Console codebase
Projects
None yet
Development

No branches or pull requests

3 participants