Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add more rules to the static analysis ruleset #1011

Open
adiviness opened this issue May 24, 2019 · 3 comments
Open

Add more rules to the static analysis ruleset #1011

adiviness opened this issue May 24, 2019 · 3 comments
Labels
Area-CodeHealth Issues related to code cleanliness, linting, rules, warnings, errors, static analysis, etc. Issue-Task It's a feature request, but it doesn't really need a major design. Product-Meta The product is the management of the products.
Milestone
Backlog

Comments

@adiviness
Copy link
Contributor

There is a ruleset file for static analysis checks at /src/StaticAnalysis.ruleset but it currently has only two rules that it checks for. More should be added.
@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels May 24, 2019
@adiviness adiviness added Area-CodeHealth Issues related to code cleanliness, linting, rules, warnings, errors, static analysis, etc. Help Wanted We encourage anyone to jump in on these. Issue-Task It's a feature request, but it doesn't really need a major design. Product-Meta The product is the management of the products. and removed Needs-Tag-Fix Doesn't match tag requirements labels May 24, 2019
@dlong11
Copy link

dlong11 commented May 25, 2019

@adiviness What is the plan here - Is it to identify which rules should be added? Then add all of the passing ones and create issues for the rest?

@adiviness
Copy link
Contributor Author

I guess this particular issue is for the general “more rules should be added” discussion. If someone wants to add a rule, they would make a new issue that specified what rule(s) they’re adding and assign the issue to themself to claim it. I’d like us to have as many checks as possible turned on and I’m sure that we’re not compliant with a bunch of them today.

@DHowett-MSFT DHowett-MSFT removed the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label May 28, 2019
@DHowett-MSFT DHowett-MSFT changed the title static analysis does not include many checks Add more rules to the static analysis ruleset May 28, 2019
@DHowett-MSFT DHowett-MSFT added this to the Terminal 1909 milestone Aug 26, 2019
@DHowett-MSFT DHowett-MSFT removed the Help Wanted We encourage anyone to jump in on these. label Aug 26, 2019
@miniksa
Copy link
Member

miniksa commented Sep 11, 2019

#2607 applied full cppwinrt ruleset to 4 projects.

@zadjii-msft zadjii-msft modified the milestones: Terminal Backlog, Backlog Jan 4, 2022
@miniksa miniksa removed their assignment Mar 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area-CodeHealth Issues related to code cleanliness, linting, rules, warnings, errors, static analysis, etc. Issue-Task It's a feature request, but it doesn't really need a major design. Product-Meta The product is the management of the products.
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
7 participants
@DHowett @adiviness @dlong11 @DHowett-MSFT @miniksa @zadjii-msft @cinnamon-msft