Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI for displaying Windows Terminal version is unexpected; suggest printing version to STDOUT rather than displaying in dialog box #10216

Closed
hcwesson opened this issue May 26, 2021 · 2 comments
Labels
Issue-Question For questions or discussion Needs-Tag-Fix Doesn't match tag requirements Resolution-Answered Related to questions that have been answered

Comments

@hcwesson
Copy link

Description of the new feature/enhancement

The wt --version command should produce textual output within the terminal context, i.e. via STDOUT; this is typical behavior for many CLI utilities. Output to STDOUT is easily parsed and script-friendly, and does not disrupt user workflow.

Examples:
python --version
image

bash --version
image

choco --version
image

As of WT version 1.9.1445.0, issuing the wt --version command spawns a dialog box with the Windows Terminal version number:
image
This is unexpected, and non-optimal for the following reasons:

  • The dialog box results in loss of focus of the terminal window
  • The version number contained in the dialog box can't be selected, and therefore can't be copied to the clipboard
  • The dialog box interface doesn't allow for (trivial) programmatic access to the version number

Proposed technical implementation details (optional)

Desired behavior: instead of outputting the current version in a dialog box, output directly to the issuing shell instance (using some facility such as the Write-Object cmdlet, possibly).

@hcwesson hcwesson added the Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. label May 26, 2021
@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels May 26, 2021
@DHowett
Copy link
Member

DHowett commented May 26, 2021

this is typical behavior for many CLI utilities

This is very much the part that makes this impossible. WT is not a CLI utility. If it were, Windows would force it to have an empty console window when we started it 😄

There's a lot (a LOT) more information in this discussion (section "displaying output in a dialog"): #4570 (comment)

@DHowett
Copy link
Member

DHowett commented May 26, 2021

There's also a plan for fixing this at the Windows OS level here: https://github.com/microsoft/terminal/blob/dev/duhowett/spec/console-allocation/doc/specs/%237335%20-%20Console%20Allocation%20Policy.md

@DHowett DHowett closed this as completed May 26, 2021
@DHowett DHowett added Issue-Question For questions or discussion Resolution-Answered Related to questions that have been answered and removed Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. Needs-Tag-Fix Doesn't match tag requirements Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels May 26, 2021
@ghost ghost added the Needs-Tag-Fix Doesn't match tag requirements label May 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue-Question For questions or discussion Needs-Tag-Fix Doesn't match tag requirements Resolution-Answered Related to questions that have been answered
Projects
None yet
Development

No branches or pull requests

2 participants