Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Light/Dark option for the Color Scheme #10224

Closed
KubaP opened this issue May 26, 2021 · 3 comments
Closed

Light/Dark option for the Color Scheme #10224

KubaP opened this issue May 26, 2021 · 3 comments
Labels
Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. Needs-Tag-Fix Doesn't match tag requirements Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting

Comments

@KubaP
Copy link

KubaP commented May 26, 2021

Description of the new feature/enhancement

Seperate light/dark Colour Scheme option. Whilst the ui elements which make up the window respond to the windows system theme setting, currently there is only the option to define one colour scheme (per theme) for the text window. With this suggestion, you would be able to define one colour scheme for when windows is set to light mode and another one for dark mode (per theme). This would be nice for those of us who change the system theme regularly, whether manually or through an automated script.

Proposed technical implementation details (optional)

Inside of the 'Colour Schemes' setting pane, have a toggle to select whether to use one or two schemes per theme; if two are selected, a secondary colour table becomes present. It would be important that the program is able to detect when the windows system theme setting changes and update the text colouring in real time, just like the winui elements already do (i.e. wouldn't require a restart of the program).

@KubaP KubaP added the Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. label May 26, 2021
@ghost ghost added Needs-Tag-Fix Doesn't match tag requirements Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels May 26, 2021
@KubaP
Copy link
Author

KubaP commented May 26, 2021

On second thought, it wouldn't be strictly necessary to define light/dark colour schemes per theme. Just the option to specify which theme to use in light mode and which theme to use in dark mode would be enough.

@j4james
Copy link
Collaborator

j4james commented May 27, 2021

This sounds very much like #4066.

@KubaP
Copy link
Author

KubaP commented May 27, 2021

Ah yes, it does indeed. I did do a quick search before filing this but seems I didn't come across that one.

@KubaP KubaP closed this as completed May 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. Needs-Tag-Fix Doesn't match tag requirements Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting
Projects
None yet
Development

No branches or pull requests

2 participants