Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Save current config as Initial #1056

Closed
Kryptryx opened this issue May 29, 2019 · 5 comments
Closed

Feature Request: Save current config as Initial #1056

Kryptryx opened this issue May 29, 2019 · 5 comments
Labels
Area-Settings Issues related to settings and customizability, for console or terminal Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. Product-Terminal The new Windows Terminal. Resolution-Fix-Available It's available in an Insiders build or a release
Milestone

Comments

@Kryptryx
Copy link

Kryptryx commented May 29, 2019

Summary of the new feature/enhancement

An option on the drop-down menu to save the current config as the initial config. In particular, the overall window position and size, and which tabs are open, and the current font size/rows/columns since it may be zoomed in/out.

I move the main window around. I resize it. I do the ctrl-scroll to get the font size where I need it. I open my preferred tabs in the preferred order. Then I want to say 'save this, and start here next time'. Not quite the same as 'restore how it was when I exited' (another fine feature).

I see there is an 'export settings' feature. This would be more of an 'export' followed by immediate import, presumably skipping the exported file.

@Kryptryx Kryptryx added the Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. label May 29, 2019
@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels May 29, 2019
@binarycrusader
Copy link
Member

binarycrusader commented May 30, 2019

This feels strongly related to #766 and #1043, although as Kryptryx suggested it's not exactly the same.

@DHowett-MSFT DHowett-MSFT added Area-Settings Issues related to settings and customizability, for console or terminal Product-Terminal The new Windows Terminal. and removed Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels May 30, 2019
@ghost ghost removed the Needs-Tag-Fix Doesn't match tag requirements label May 30, 2019
@zadjii-msft zadjii-msft added this to the Terminal Backlog milestone Jun 19, 2019
@zadjii-msft
Copy link
Member

Hey so we discussed this yesterday.

We could maybe add a ShortcutAction that gets the runtime position, opacity, fontSize, etc, and writes them back to the profiles.json in the current state. We'd want to do this very carefully, because as of #2475, we're not in the business of re-serializing the settings, so we'd want to do a careful insertion.

By making it a ShortcutAction, we could pair it with #2046 / #2193.

I'd also want that action to be spec'd before work starts on it. What settings would be persisted? How do we handle global settings vs per-profile settings? There's much to work out here.

In fact, with #1142, we could maybe add an optional arg that specified which parts of the current state you wanted to save (though that might be overkill)

@fishzle

This comment was marked as off-topic.

@jamietre
Copy link

There should be at least a way to restore the open tabs/window split state, and current directories of each terminal. This feature is found on popular terminals for other platforms, e.g. iTerm2 on OSX and Guake on Linux. Since this is a very small amount of data, it could easily just be stored in the config file, allowing users to self manage it.

@zadjii-msft
Copy link
Member

Looking over this issue again, and I think we may want to just close this out. We've got "firstWindowPreference": "persistedWindowLayout" which pretty much covers this use case. There are additional follow ups in #9800, and might be a good thread for more discussions.

#11526 is gonna track "add support for creating a command that can reopen this specific set of tabs&panes", which is similar to this (if you don't want to just always restore the existing layout).

@zadjii-msft zadjii-msft closed this as not planned Won't fix, can't repro, duplicate, stale Aug 3, 2022
@ghost ghost added the Needs-Tag-Fix Doesn't match tag requirements label Aug 3, 2022
@zadjii-msft zadjii-msft added the Resolution-Fix-Available It's available in an Insiders build or a release label Aug 3, 2022
@ghost ghost removed the Needs-Tag-Fix Doesn't match tag requirements label Aug 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Settings Issues related to settings and customizability, for console or terminal Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. Product-Terminal The new Windows Terminal. Resolution-Fix-Available It's available in an Insiders build or a release
Projects
None yet
Development

No branches or pull requests

6 participants