Bell sound on git hooks scripts not working

[KeterSCP]

Windows Terminal version (or Windows build number)

1.10.2383.0

Other Software

git 2.31.1.windows.1

Steps to reproduce

1. Enable Audible bell notification style for the powershell or cmd profile in the windows terminal.
2. Create an empty repo.
3. In .git/hooks folder add post-checkout file with following content:

#!/bin/bash                                                                      

tput setaf 1 # set red foreground

echo 'Here the bell sound should appear'

tput bel # make a sound

tput sgr0 # reset

4. Add a dummy file and commit it to initialize the branch.
5. Open repo folder in powershell or cmd profile in windows terminal.
6. Execute git checkout command

Expected Behavior

The bell should be triggered

Actual Behavior

Bell is not triggered.

When repeating mentioned steps from windows powershell or cmd (not from the windows terminal), the bell is being triggered.

[zadjii-msft]

weird. What Windows version are you on?

[zadjii-msft]

Woah okay this is something else. In this scenario, the Terminal doesn't even get a BEL. Like, one never gets written to the conpty connection. I worry that the bash.exe that msys ships doesn't actually bell with BEL. Hmmmmmmm

[elsaco]

FYI: Git for Windows has the bell style set to visible, by default. See /etc/inputrc for details.

Sample reading on git version 2.30.1.windows.1:

# none, visible or audible
set bell-style visible

[zadjii-msft]

FYI: Git for Windows has the bell style set to visible, by default.

I'm not sure that's relevant in this case - I believe that only applies to the bell emitted on input. For example, typing asdf at a git bash prompt, then hitting tab.

Changing that does emit a bell sound correctly in the Terminal, but not in this weird git checkout repro. Heck, even a tput bel in git bash will emit a bell, but again, not in this weird scenario. I'm wondering if they're detecting they're not attached to a console and skipping it somehow?

Clearly something is special about this case, because slapping a infocmp in the post-checkout shows that the Terminal is running with TERM=cygwin in a post-checkout, which is I guess fine because bel=^G, in both xterm-256color and cygwin

[DHowett]

the Terminal is running with TERM=cygwin in a post-checkout

This is absolutely the issue. When TERM=cygwin, all output from Cygwin (also msys2) applications is routed through their "console file handler." It implements, among other things, its own VT parser.

It also handles bell on its own.

https://github.com/Alexpux/Cygwin/blob/b61dc22adaf82114eee3edce91cc3433bcd27fe5/winsup/cygwin/fhandler_console.cc#L2566-L2568

It manually writes C:\windows\media\ding.wav into the user's AppEvents configuration, and then triggers a MessageBeep. It literally reconfigures the OS to set MessageBeep to ding.wav and then calls it.

This is 100% on the Cygwin/MSYS2 runtime. It is equal parts (also 100%!) on Git-for-windows for choosing TERM=cygwin for checkout hooks.