Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Terminal Core: Whenever we scroll the buffer, we RepaintAll #1182

Closed
zadjii-msft opened this issue Jun 9, 2019 · 2 comments
Closed

Terminal Core: Whenever we scroll the buffer, we RepaintAll #1182

zadjii-msft opened this issue Jun 9, 2019 · 2 comments
Assignees
@miniksa
Labels
Area-Performance Performance-related issue Area-TerminalControl Issues pertaining to the terminal control (input, selection, keybindings, mouse interaction, etc.) Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-1 A description (P1) Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Milestone
Terminal v1.0

Comments

@zadjii-msft
Copy link
Member

In Terminal::_WriteBuffer, when we scroll the buffer, we tell the renderer to TriggerRedrawAll. This isn't necessary, we should probably just be telling the renderer to scroll the lines on screen.

The RedrawAll call was just a kludge while we were getting the Terminal stood up. Now that everything's working a bit better, we should make sure that RedrawAll is only called when absolutely necessary.
@zadjii-msft zadjii-msft added Issue-Bug It either shouldn't be doing this or needs an investigation. Area-TerminalControl Issues pertaining to the terminal control (input, selection, keybindings, mouse interaction, etc.) Product-Terminal The new Windows Terminal. labels Jun 9, 2019
@zadjii-msft zadjii-msft added this to the Terminal v1.0 milestone Jun 9, 2019
@ghost ghost added the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Jun 9, 2019
@DHowett-MSFT DHowett-MSFT removed the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Jun 10, 2019
@zadjii-msft zadjii-msft added Area-Performance Performance-related issue Priority-3 A description (P3) labels Jan 22, 2020
@DHowett-MSFT
Copy link
Contributor

Related to #778.

@cinnamon-msft cinnamon-msft added Priority-1 A description (P1) and removed Priority-3 A description (P3) labels Feb 28, 2020
@miniksa
Copy link
Member

miniksa commented Apr 15, 2020

This was resolved in #5185

@miniksa miniksa closed this as completed Apr 15, 2020
@ghost ghost added the Needs-Tag-Fix Doesn't match tag requirements label Apr 15, 2020
@miniksa miniksa added the Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release. label Apr 15, 2020
@ghost ghost removed the Needs-Tag-Fix Doesn't match tag requirements label Apr 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@miniksa miniksa

Labels
Area-Performance Performance-related issue Area-TerminalControl Issues pertaining to the terminal control (input, selection, keybindings, mouse interaction, etc.) Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-1 A description (P1) Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Projects
None yet
Milestone
Terminal v1.0
Development

No branches or pull requests
4 participants
@DHowett-MSFT @miniksa @zadjii-msft @cinnamon-msft