Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scrolling doesn't work sometimes #11928

Closed
TheBicPen opened this issue Dec 12, 2021 · 2 comments
Closed

Scrolling doesn't work sometimes #11928

TheBicPen opened this issue Dec 12, 2021 · 2 comments
Labels
Needs-Tag-Fix Doesn't match tag requirements Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Resolution-External For issues that are outside this codebase

Comments

@TheBicPen
Copy link

Windows Terminal version

1.11.2921.0

Windows build number

10.0.19044

Other Software

I've only seen the bug when running this program: https://github.com/JustArchiNET/ArchiSteamFarm.
I tried running cat * in a folder with many files to see if the same issue occurs, but it does not.
Nor does it occur with for ($i=0; $i -le 10; $i++) {echo 'a'; sleep 1}.

Steps to reproduce

Download the program and prerequisites from: https://github.com/JustArchiNET/ArchiSteamFarm/releases/tag/5.2.0.10 (win x64)
Run it in a powershell tab in terminal.
While the program is running, scrolling with the scrollwheel does not work.
Ctrl+Shift+up/down and dragging the scrollbar both work as expected.

Expected Behavior

Scrolling with the scrollwheel works while the program is running.
I don't know if the program is somehow capturing the scroll events, but I wouldn't expect a program to be able to do that.

Actual Behavior

While the program is running, scrolling with the scrollwheel does not work.
Ctrl+Shift+up/down and dragging the scrollbar both work as expected.

@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Dec 12, 2021
@zadjii-msft
Copy link
Member

@zadjii-msft
Copy link
Member

So this is kinda like what's happening with vim.exe in: #9970 (comment)

ArchiStreamFarm is disabling quick edit when it starts up: https://github.com/JustArchiNET/ArchiSteamFarm/blob/07348a5958550c6c3fa9ddef18f8db51c3818c54/ArchiSteamFarm/Core/OS.cs#L107-L110

That's being combined with the fact that the console is already in mouse input mode, so now they're getting mouse input events (including scrolling/mouse-wheel events), rather than letting them be handled by the Terminal. This has the end result of the Terminal not scrolling when you wheel over it, because we're just sending those to the client application.

This should be filed upstream over at https://github.com/JustArchiNET/ArchiSteamFarm/issues, they should be able to patch this to disable ENABLE_MOUSE_INPUT when they're also disabling quick edit.

@zadjii-msft zadjii-msft added the Resolution-External For issues that are outside this codebase label Dec 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs-Tag-Fix Doesn't match tag requirements Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Resolution-External For issues that are outside this codebase
Projects
None yet
Development

No branches or pull requests

2 participants