Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search is often broken while console process is running #1215

Open
asklar opened this issue Jun 12, 2019 · 7 comments · Fixed by #15858
Open

Search is often broken while console process is running #1215

asklar opened this issue Jun 12, 2019 · 7 comments · Fixed by #15858
Labels
Area-Interaction Interacting with the vintage console window (as opposed to driving via API or hooks) Help Wanted We encourage anyone to jump in on these. Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-3 A description (P3) Product-Conhost For issues in the Console codebase
Milestone

Comments

@asklar
Copy link
Member

asklar commented Jun 12, 2019

Environment

Windows build number: 10.0.18362.113
Windows Terminal version (if applicable):

Any other software?

Steps to reproduce

have a long running process (e.g. msbuild), and ctrl+F to find something. Often the match will be off by one line
10.0.18362.113

Expected behavior

I can find the text properly

Actual behavior

The text that gets selected when searching is not the right text

@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Jun 12, 2019
@asklar
Copy link
Member Author

asklar commented Jun 12, 2019

image

note that the line that conhost selects is not the one with the text "file not found" (not shown since the buffer scrolled) but the next one.

@zadjii-msft zadjii-msft added Area-Interaction Interacting with the vintage console window (as opposed to driving via API or hooks) Issue-Bug It either shouldn't be doing this or needs an investigation. Product-Conhost For issues in the Console codebase labels Jun 12, 2019
@ghost ghost removed the Needs-Tag-Fix Doesn't match tag requirements label Jun 12, 2019
@zadjii-msft zadjii-msft added this to the 20H1 milestone Jun 12, 2019
@DHowett-MSFT DHowett-MSFT removed the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Jun 13, 2019
@DHowett-MSFT
Copy link
Contributor

This is probably not a new regression; I think we probably broke this in RS5.

@DHowett-MSFT DHowett-MSFT added the Priority-3 A description (P3) label Sep 5, 2019
@DHowett-MSFT DHowett-MSFT modified the milestones: 20H1, 21H1 Sep 25, 2019
@rkeithhill

This comment has been minimized.

@DHowett-MSFT

This comment has been minimized.

@rkeithhill

This comment has been minimized.

@zadjii-msft zadjii-msft modified the milestones: Windows vNext, Backlog Jan 4, 2022
@zadjii-msft zadjii-msft added the Help Wanted We encourage anyone to jump in on these. label Jan 4, 2022
@zadjii-msft
Copy link
Member

Pretty sure this is fixed by #15858

@zadjii-msft zadjii-msft modified the milestones: Backlog, Terminal v1.19 Aug 23, 2023
@zadjii-msft zadjii-msft linked a pull request Sep 7, 2023 that will close this issue
@zadjii-msft
Copy link
Member

This didn't look fixed in the conhost in 26051.1000.amd64fre.ge_release_we_adept.240201-1823. I don't know if that has the FI including the updated console code from main though.

But also: that doesn't seem to matter. Still broken in openconsole as of ef96e22.

@zadjii-msft zadjii-msft modified the milestones: Terminal v1.20, Backlog Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Interaction Interacting with the vintage console window (as opposed to driving via API or hooks) Help Wanted We encourage anyone to jump in on these. Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-3 A description (P3) Product-Conhost For issues in the Console codebase
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants