Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[VT Render] Investigate not breaking lines for node-pty #1227

Closed
zadjii-msft opened this issue Jun 12, 2019 · 2 comments
Closed

[VT Render] Investigate not breaking lines for node-pty #1227

zadjii-msft opened this issue Jun 12, 2019 · 2 comments
Labels
Area-Rendering Text rendering, emoji, complex glyph & font-fallback issues Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Tag-Fix Doesn't match tag requirements Priority-2 A description (P2) Product-Conpty For console issues specifically related to conpty
Milestone
Windows vNext

Comments

@zadjii-msft
Copy link
Member

zadjii-msft commented Jun 12, 2019 •
edited
Loading

From MSFT:19012792

I didn't have any details in here. I presume that this was to track trying to not render a \r\n at the end of a line, so that a terminal would wrap the line itself. IIRC I tried that in RS5, but it broke something else, and there wasn't time to get it working for that release, so we reverted it.
@zadjii-msft zadjii-msft added Product-Conhost For issues in the Console codebase Issue-Bug It either shouldn't be doing this or needs an investigation. labels Jun 12, 2019
@zadjii-msft zadjii-msft added this to the 20H1 milestone Jun 12, 2019
@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Jun 12, 2019
@zadjii-msft zadjii-msft added Area-Rendering Text rendering, emoji, complex glyph & font-fallback issues Product-Conpty For console issues specifically related to conpty and removed Product-Conhost For issues in the Console codebase labels Jun 12, 2019
@ghost ghost removed the Needs-Tag-Fix Doesn't match tag requirements label Jun 12, 2019
@zadjii-msft zadjii-msft removed the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Jun 12, 2019
@JDTX
Copy link

JDTX commented Jul 2, 2019

Related: #405

@zadjii-msft zadjii-msft modified the milestones: 20H1, 20H2 Aug 27, 2019
@zadjii-msft zadjii-msft added the Priority-2 A description (P2) label Jan 4, 2022
@zadjii-msft
Copy link
Member Author

I've been up and down the internal PRs around this time, and I can't find where this originally came from. The original bug has no details in it other than "it was a revert of something in the RS5 timeframe". I recall making some change to wrapping and having to revert it, but I can't find it, or the original bug.

Chances are, we've already fixed this along the way. I'm closing this.

@ghost ghost added the Needs-Tag-Fix Doesn't match tag requirements label Jan 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area-Rendering Text rendering, emoji, complex glyph & font-fallback issues Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Tag-Fix Doesn't match tag requirements Priority-2 A description (P2) Product-Conpty For console issues specifically related to conpty
Projects
None yet
Milestone
Windows vNext
Development

No branches or pull requests
2 participants
@zadjii-msft @JDTX