Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bottom part of SUI has a giant black bar on it #12271

Closed
elsaco opened this issue Jan 27, 2022 · 3 comments
Closed

Bottom part of SUI has a giant black bar on it #12271

elsaco opened this issue Jan 27, 2022 · 3 comments
Assignees
@PankajBhojwani
Labels
Area-Settings UI Anything specific to the SUI Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Priority-3 A description (P3) Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Milestone
Terminal v1.13

Comments

@elsaco
Copy link

elsaco commented Jan 27, 2022

Windows Terminal version

main a13b207

Windows build number

10.0.22000.0

Other Software

No response

Steps to reproduce

Build a13b207

Expected Behavior

Windows 11 style applied to each SUI element.

Actual Behavior

Discard charges almost indistinguishable from the black background:

wt_dev_settings

Non-Win11 style:

wt_pre_settings
@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Jan 27, 2022
@zadjii-msft
Copy link
Member

We're already working on that over in #11720 and #12144

@zadjii-msft zadjii-msft changed the title Apply Windows 11 style to each SUI section Bottom part of SUI has a giant black bar on it Jan 28, 2022
@zadjii-msft zadjii-msft added Area-Settings UI Anything specific to the SUI Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-3 A description (P3) labels Jan 28, 2022
@zadjii-msft zadjii-msft added this to the Terminal v1.13 milestone Jan 28, 2022
@zadjii-msft zadjii-msft added the Product-Terminal The new Windows Terminal. label Jan 28, 2022
@ghost ghost removed the Needs-Tag-Fix Doesn't match tag requirements label Jan 28, 2022
@PankajBhojwani
Copy link
Contributor

Yep, this was fixed in #11720

@PankajBhojwani PankajBhojwani added the Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release. label Jan 28, 2022
@zadjii-msft
Copy link
Member

Nice

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@PankajBhojwani PankajBhojwani

Labels
Area-Settings UI Anything specific to the SUI Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Priority-3 A description (P3) Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Projects
None yet
Milestone
Terminal v1.13
Development

No branches or pull requests
3 participants
@elsaco @zadjii-msft @PankajBhojwani