Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add icons to new SUI expanders #12359

Open
Tracked by #11353
Tropix126 opened this issue Feb 3, 2022 · 1 comment
Open
Tracked by #11353

Add icons to new SUI expanders #12359

Tropix126 opened this issue Feb 3, 2022 · 1 comment
Labels
Area-Settings UI Anything specific to the SUI Help Wanted We encourage anyone to jump in on these. Issue-Task It's a feature request, but it doesn't really need a major design. Product-Terminal The new Windows Terminal.
Milestone
Backlog

Comments

@Tropix126
Copy link

Tropix126 commented Feb 3, 2022 •
edited
Loading

Description of the new feature/enhancement

The new Settings UI in terminal utilizes expanders to group settings controls, which matches up with the other inbox apps shipped in Windows 11. Something that I believe should be added (both for the sake of consistency and visual hierarchy) is expander icons.

At the moment, most inbox apps add an icon prefixed before each settings group that conveys it's semantic meaning. This both looks nice and makes it easier to quickly differentiate between groups.

Current:
image

Notepad:
image

Clock:
image

It's worth noting that not every app does this. For example, Snipping Tool has no icons in it's expanders, although I do still believe this could be an improvement.
@Tropix126 Tropix126 added the Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. label Feb 3, 2022
@ghost ghost added Needs-Tag-Fix Doesn't match tag requirements Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels Feb 3, 2022
@zadjii-msft
Copy link
Member

This seems like a good idea to me

@zadjii-msft zadjii-msft added Area-Settings UI Anything specific to the SUI Help Wanted We encourage anyone to jump in on these. Issue-Task It's a feature request, but it doesn't really need a major design. Product-Terminal The new Windows Terminal. and removed Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. labels Feb 4, 2022
@ghost ghost removed the Needs-Tag-Fix Doesn't match tag requirements label Feb 4, 2022
@zadjii-msft zadjii-msft added this to the Backlog milestone Feb 4, 2022
@zadjii-msft zadjii-msft mentioned this issue Feb 4, 2022
Closed
17 tasks
@zadjii-msft zadjii-msft removed the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Feb 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area-Settings UI Anything specific to the SUI Help Wanted We encourage anyone to jump in on these. Issue-Task It's a feature request, but it doesn't really need a major design. Product-Terminal The new Windows Terminal.
Projects
Terminal Walkthroughs
Status: Should be written
Milestone
Backlog
Development

No branches or pull requests
2 participants
@zadjii-msft @Tropix126