Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Actions, Color Schemes pages in SUI to match Controlsv2 style #12388

Open
Tracked by #12400
elsaco opened this issue Feb 5, 2022 · 5 comments
Open
Tracked by #12400

Update Actions, Color Schemes pages in SUI to match Controlsv2 style #12388

elsaco opened this issue Feb 5, 2022 · 5 comments
Labels
Area-SettingsUI Anything specific to the SUI Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. Priority-1 A description (P1) Product-Terminal The new Windows Terminal.
Milestone
Backlog

Comments

@elsaco
Copy link

elsaco commented Feb 5, 2022

Windows Terminal version

1.13.10336.0

Windows build number

10.0.19044.0

Other Software

No response

Steps to reproduce

  • open SUI and maximize terminal or Close Navigation (maximized is move visible)
  • go to Defaults or Rendering

Expected Behavior

  • text aligns with other SUI elements

Actual Behavior

wt_sui_align
@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Feb 5, 2022
@j4james
Copy link
Collaborator

j4james commented Feb 6, 2022

I also think the alignment feels wrong on the Color schemes and Actions pages. The contents of those pages is centered, but the titles are way off to the left. I'm assuming that's intended match the title position on the other pages, but then I'd expect the content to be similarly left aligned rather than centered. As it is, it just looks broken to me.

@zadjii-msft
Copy link
Member

This might already be fixed in #12374, @PankajBhojwani to confirm the bit about the ColorSchemes and Actions pages too

@zadjii-msft zadjii-msft added Area-SettingsUI Anything specific to the SUI Priority-3 A description (P3) Product-Terminal The new Windows Terminal. zPreview-Service-Queued-1.13 A floating label that tracks the current Preview version for servicing purposes. labels Feb 7, 2022
@zadjii-msft zadjii-msft added this to the Terminal v1.14 milestone Feb 7, 2022
@zadjii-msft zadjii-msft mentioned this issue Feb 7, 2022
Open
12 tasks
@PankajBhojwani
Copy link
Contributor

The disclaimer text on the Rendering and Defaults pages is fixed in #12374. As for the ColorSchemes and Actions pages, those pages have not yet been updated to the new style - once we get to updating those pages the alignment will be fixed. (We have to do some amount of backend work first before we can get to updating those pages - mainly implementing the MVVM pattern there).

@zadjii-msft zadjii-msft removed the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Feb 8, 2022
@zadjii-msft zadjii-msft changed the title SUI text alignment Update Actions, Color Schemes pages in SUI to match Controlsv2 style Mar 10, 2022
@zadjii-msft zadjii-msft removed the zPreview-Service-Queued-1.13 A floating label that tracks the current Preview version for servicing purposes. label Mar 10, 2022
@zadjii-msft zadjii-msft modified the milestones: Terminal v1.14, 22H1 Mar 10, 2022
@zadjii-msft zadjii-msft added the Issue-Task It's a feature request, but it doesn't really need a major design. label Mar 10, 2022
@ghost ghost removed the Needs-Tag-Fix Doesn't match tag requirements label Mar 10, 2022
@zadjii-msft
Copy link
Member

Repurposing this to track the rejuv for those pages, and retitling. We've been using this to track that work anyways, the title may as well match.

Punted out of 1.14 because we don't have runway for the refactor required here.

Greatly trimmed Teams chat regarding design:

image

Then the expander gives a place for action args once we get those into the SUI

so expanded, that's got the action dropdown and the keybinding editor, and the.... delete button?

Yeah I'm thinking like this
image

Then since it's a text box inside the expander, it should show up on the top of the expander itself

okay so the expander content would basically just be what we have for the action now

@zadjii-msft zadjii-msft mentioned this issue May 9, 2022
Closed
@zadjii-msft zadjii-msft mentioned this issue Jun 13, 2022
Open
@zadjii-msft zadjii-msft added Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. Priority-1 A description (P1) and removed Issue-Task It's a feature request, but it doesn't really need a major design. Priority-3 A description (P3) labels Jun 13, 2022
@zadjii-msft
Copy link
Member

See also

@zadjii-msft zadjii-msft modified the milestones: 22H1, Terminal v1.16 Jun 22, 2022
This was referenced Jul 25, 2022
Open
Closed
@zadjii-msft zadjii-msft modified the milestones: Terminal v1.17, Backlog Jan 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area-SettingsUI Anything specific to the SUI Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. Priority-1 A description (P1) Product-Terminal The new Windows Terminal.
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
4 participants
@elsaco @j4james @zadjii-msft @PankajBhojwani