Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Font resize breaks selection #1434

Closed
mcpiroman opened this issue Jun 22, 2019 · 2 comments
Closed

Font resize breaks selection #1434

mcpiroman opened this issue Jun 22, 2019 · 2 comments
Labels
Needs-Tag-Fix Doesn't match tag requirements Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing.

Comments

@mcpiroman
Copy link
Contributor

Commit ce4c6d6

When Ctrl+Mouse wheel, selected span changes. This seems related to #1368, but is different in that when returning to previous size, selection is invalid.
@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Jun 22, 2019
@Karl-WE
Copy link

Karl-WE commented Jun 23, 2019

repro:
select text in windows terminal
agree using ctrl+mousewheel up and down to resize text (it does likely happen if you scale it by more than 3 pt)
either selection moves up or it got deselected.

deselection happens more often than the selection move. it also depends whether you make multiline selection starting in the middle or from the top of the text or if you just make partly multiline selection that do not start from char 1 in a line.
hope this helps.

@DHowett-MSFT
Copy link
Contributor

We should just tackle this as part of #1368.

@DHowett-MSFT DHowett-MSFT added the Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing. label Jun 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Needs-Tag-Fix Doesn't match tag requirements Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@DHowett-MSFT @mcpiroman @Karl-WE