-
Notifications
You must be signed in to change notification settings - Fork 8.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Setting Appearance to "Use Windows Theme" only half respects it #14760
Comments
Ah so, yes, this might need to be clarified too. This is a side effect of some of the Theme changes in 1.16. I'm workshopping some messaging in MicrosoftDocs/terminal#635 (comment). I'll add a note about this. Basically, in 1.16, the default themes will always use the Terminal's background color as the default color for the tab. So, in the default case, with a black terminal window, you're going to get a black tab. With a blue color scheme (like Campbell PowerShell), you'll get a blue tab. This is to give the Terminal that "seemless" feel. In light mode, that obviously creates a bit of a weird case where you get a black tab on a white tab row. No worries though! With 1.16, you can customize the theme of the Terminal in lots of new ways. So, if you want a theme where the tabs are white again, you can do something like: "theme": "White Tabs",
"themes":
[
{
"name": "White Tabs",
"tab":
{
"background": "#ffffffff",
},
"window":
{
"applicationTheme": "light"
}
},
] ALTERNATIVELY, you could set the color scheme of the Terminal to something with a white background. If you're using light theme, then maybe that's what you want? 1.17 is going to make this even better, because we've added the ability to set different color schemes depending on the theme of the window, so you can set your scheme like: "colorScheme":
{
"light": "One Half Light",
"dark": "One Half Dark",
}, and now presto - the terminal background will change in accordance with the Does that all make sense/? |
Apologies, github didn't alert me to your response. While I suppose it makes sense the method to meet my expectations is, well, complicated. I suppose this boils down to a difference of opinions on whether the tab is part of the individual prompt window or part of the UI of terminal itself. Windows itself had real problems with Task Manager when you mixed light and dark mode too. That light mode produces "odd" results is perhaps an assumption on what developers prefer - it's almost a VI versus EMACS religious crusade, but at my age light mode is easier on the eyes. I'm afraid I agree with @fxzxmic here. A setting of "Use Windows color schemes" rather than the terminal unique ones would be simpler. I don't want white tabs, I want it to match Windows itself, depending on what the current Windows schemes are, but even that may still have the same problem, depending on how you see the tab ownership. It becomes a question of do you mimic windows, or do you go your own way? |
To me, the UI, and the "content" inside (or the "canvas"), are two different parts. The UI should be controlled by the theme, while the canvas should be controlled by something else (in WT's case, the color scheme for that profile). Just like the you can set page color in Word without affecting the UI elements. Or how tabs look like in browsers. Another change I don't understand is why it defaults to dark instead of "use Windows theme". |
I'm gonna close this to merge the discussion with /dup #14815 |
Hi! We've identified this issue as a duplicate of another one that already exists on this Issue Tracker. This specific instance is being closed in favor of tracking the concern over on the referenced thread. Thanks for your report! |
Windows Terminal version
1.16.10261.09
Windows build number
10.0.22621.0
Other Software
No response
Steps to reproduce
Change settings in Terminal to Use Windows Theme
Set Windows to have WIndows Mode as Dark and App Mode as Light
Glare at tab background colour in disgust
Expected Behavior
In mixed dark/light other apps, such as Edge and Explorer, use the app colour for the tab background, I would expect Terminal to do the same, rather than end up with a dark tab background
Actual Behavior
The tab background is always dark.
The text was updated successfully, but these errors were encountered: