Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setting Appearance to "Use Windows Theme" only half respects it #14760

Closed
blowdart opened this issue Jan 30, 2023 · 6 comments
Closed

Setting Appearance to "Use Windows Theme" only half respects it #14760

blowdart opened this issue Jan 30, 2023 · 6 comments
Assignees
Labels
Issue-Bug It either shouldn't be doing this or needs an investigation. Issue-Question For questions or discussion Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing.

Comments

@blowdart
Copy link

blowdart commented Jan 30, 2023

Windows Terminal version

1.16.10261.09

Windows build number

10.0.22621.0

Other Software

No response

Steps to reproduce

Change settings in Terminal to Use Windows Theme
Set Windows to have WIndows Mode as Dark and App Mode as Light
Glare at tab background colour in disgust

Expected Behavior

In mixed dark/light other apps, such as Edge and Explorer, use the app colour for the tab background, I would expect Terminal to do the same, rather than end up with a dark tab background

Screenshot 2023-01-30 045815

Actual Behavior

Screenshot 2023-01-30 045258

The tab background is always dark.

@blowdart blowdart added Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels Jan 30, 2023
@zadjii-msft zadjii-msft added the Issue-Question For questions or discussion label Jan 30, 2023
@zadjii-msft
Copy link
Member

Ah so, yes, this might need to be clarified too. This is a side effect of some of the Theme changes in 1.16. I'm workshopping some messaging in MicrosoftDocs/terminal#635 (comment). I'll add a note about this.

Basically, in 1.16, the default themes will always use the Terminal's background color as the default color for the tab. So, in the default case, with a black terminal window, you're going to get a black tab. With a blue color scheme (like Campbell PowerShell), you'll get a blue tab. This is to give the Terminal that "seemless" feel.

In light mode, that obviously creates a bit of a weird case where you get a black tab on a white tab row. No worries though! With 1.16, you can customize the theme of the Terminal in lots of new ways. So, if you want a theme where the tabs are white again, you can do something like:

    "theme": "White Tabs",
    "themes":
    [
        {
            "name": "White Tabs",
            "tab":
            {
                "background": "#ffffffff",
            },
            "window":
            {
                "applicationTheme": "light"
            }
        },
    ]

ALTERNATIVELY, you could set the color scheme of the Terminal to something with a white background. If you're using light theme, then maybe that's what you want?

1.17 is going to make this even better, because we've added the ability to set different color schemes depending on the theme of the window, so you can set your scheme like:

"colorScheme":
{
    "light": "One Half Light",
    "dark": "One Half Dark",
},

and now presto - the terminal background will change in accordance with the window.applicationTheme of the Terminal.

Does that all make sense/?

@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something label Feb 2, 2023
@fxzxmic
Copy link

fxzxmic commented Feb 9, 2023

image
I'm glad to see that there is still a solution, because I really don't like this feature, which is too odd. I prefer dark interfaces but bright tabs.

And it seems that 1.17 has made an interesting attempt to provide more customizable features. But I think if it would be better to add tab color setting to the color scheme? You cannot follow the system mode if you set it alone. Or add system option for the tab background.

@blowdart
Copy link
Author

blowdart commented Feb 9, 2023

Apologies, github didn't alert me to your response.

While I suppose it makes sense the method to meet my expectations is, well, complicated. I suppose this boils down to a difference of opinions on whether the tab is part of the individual prompt window or part of the UI of terminal itself. Windows itself had real problems with Task Manager when you mixed light and dark mode too.

That light mode produces "odd" results is perhaps an assumption on what developers prefer - it's almost a VI versus EMACS religious crusade, but at my age light mode is easier on the eyes.

I'm afraid I agree with @fxzxmic here. A setting of "Use Windows color schemes" rather than the terminal unique ones would be simpler. I don't want white tabs, I want it to match Windows itself, depending on what the current Windows schemes are, but even that may still have the same problem, depending on how you see the tab ownership. It becomes a question of do you mimic windows, or do you go your own way?

@microsoft-github-policy-service microsoft-github-policy-service bot added Needs-Attention The core contributors need to come back around and look at this ASAP. and removed Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something labels Feb 9, 2023
@fireattack
Copy link

To me, the UI, and the "content" inside (or the "canvas"), are two different parts.

The UI should be controlled by the theme, while the canvas should be controlled by something else (in WT's case, the color scheme for that profile).

Just like the you can set page color in Word without affecting the UI elements. Or how tabs look like in browsers.

Another change I don't understand is why it defaults to dark instead of "use Windows theme".

@zadjii-msft
Copy link
Member

I'm gonna close this to merge the discussion with /dup #14815

@zadjii-msft zadjii-msft closed this as not planned Won't fix, can't repro, duplicate, stale Feb 10, 2023
@microsoft-github-policy-service
Copy link
Contributor

Hi! We've identified this issue as a duplicate of another one that already exists on this Issue Tracker. This specific instance is being closed in favor of tracking the concern over on the referenced thread. Thanks for your report!

@microsoft-github-policy-service microsoft-github-policy-service bot added Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing. and removed Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Attention The core contributors need to come back around and look at this ASAP. labels Feb 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue-Bug It either shouldn't be doing this or needs an investigation. Issue-Question For questions or discussion Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing.
Projects
None yet
Development

No branches or pull requests

4 participants