Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve glyph spacing for serif fonts #15181

Closed
AlLiberali opened this issue Apr 14, 2023 · 8 comments
Closed

Improve glyph spacing for serif fonts #15181

AlLiberali opened this issue Apr 14, 2023 · 8 comments
Labels
Area-AtlasEngine Issue-Task It's a feature request, but it doesn't really need a major design. Needs-Tag-Fix Doesn't match tag requirements Product-Terminal The new Windows Terminal.

Comments

@AlLiberali
Copy link

Description of the new feature/enhancement

I know that this may sound psychopathic to most developers but I'd like to use a font like Times New Roman or Garamond for my console. I use Cmder/ConEmu as well which does render these fonts just fine so please fix this:

Capture

Here is Cmder:
image

@AlLiberali AlLiberali added the Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. label Apr 14, 2023
@microsoft-github-policy-service microsoft-github-policy-service bot added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Apr 14, 2023
@lhecker
Copy link
Member

lhecker commented Apr 14, 2023

Would text rendering like this already be fine for you:
image

Or do you specifically want to have proportional text rendering like in Cmder?

@AlLiberali
Copy link
Author

That certainly looks more consistent and I'd appreciate it but I kind of expected an advanced terminal such as Windows Terminal to be able to beat Notepad in rendering text.

@lhecker
Copy link
Member

lhecker commented Apr 14, 2023

but I kind of expected an advanced terminal such as Windows Terminal to be able to beat Notepad in rendering text.

I‘m open to improving our support for proportional fonts, but I don’t understand what you’re trying to say here. The first half of your response sounds like improving the spacing would be enough, but the second half (the one after "but") sounds like it isn’t? In what other way would you like us to beat Notepad besides making the spacing more consistent? I don’t mean to be rude, but could you please be more precise in your feature request(s)? Otherwise I‘ll repurpose this feature request as one just asking for us to improve the spacing of proportional fonts, if that’s fine, because from a technical standpoint I don’t think we‘ll support full proportional rendering the way Cmder does it soon, due to the unclarity around cell-wise background coloring.

@AlLiberali
Copy link
Author

AlLiberali commented Apr 14, 2023

Well yes; I would like fully proportional rendering. But since that'd be difficult, fixing the spacing would do for now. Thank you in advance.

@lhecker lhecker changed the title Serif font rendering issue Improve glyph spacing for serif fonts Apr 15, 2023
@lhecker lhecker added Product-Terminal The new Windows Terminal. Issue-Task It's a feature request, but it doesn't really need a major design. Area-AtlasEngine and removed Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. labels Apr 15, 2023
@microsoft-github-policy-service microsoft-github-policy-service bot removed the Needs-Tag-Fix Doesn't match tag requirements label Apr 15, 2023
@j4james
Copy link
Collaborator

j4james commented Apr 15, 2023

See also #13389.

@WSLUser
Copy link
Contributor

WSLUser commented Apr 19, 2023

I do think proper font support for all fonts, not just monospaced should be the goal. We can have all these fancy features with even more desired (like getting sixel support even) but proper font support is one of those basic requirements for a terminal and should be prioritized over any new features and functionality. Getting the rendering correct for these other fonts could be difficult to do but obviously can and has been done by other terminals and so should be elevated over other requests. Being able to choose any font you want and simply work would be appreciated far more than anything else.

@DHowett
Copy link
Member

DHowett commented Apr 19, 2023

Proper support for proportional fonts in a primarily monospaced ecosystem should not be prioritized over any other requests. That's honestly probably the last thing we should work on. 😄

@carlos-zamora carlos-zamora removed the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Apr 26, 2023
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Tag-Fix Doesn't match tag requirements label Apr 26, 2023
@DHowett
Copy link
Member

DHowett commented Apr 26, 2023

After a discussion with the team, we're feeling pretty ready to close this out. I appreciate that some folks want to use proportional fonts, but right now it's not in plan for our engineering team and we don't have the capacity to review a community pull request that adds support for them.

We may make improvements to how they're displayed in the future, but we'll probably never commit to being as competent at it as Word or Notepad or richedit... or even cmder.

FWIW: How does cmder handle midnight commander? o_O

I'd be worried it turns out like this:
image

@DHowett DHowett closed this as completed Apr 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-AtlasEngine Issue-Task It's a feature request, but it doesn't really need a major design. Needs-Tag-Fix Doesn't match tag requirements Product-Terminal The new Windows Terminal.
Projects
None yet
Development

No branches or pull requests

6 participants