Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Italic characters stripped down in neovim (other terminals do not have this issue) #15246

Closed
gwjulian opened this issue Apr 27, 2023 · 8 comments
Labels
Issue-Bug It either shouldn't be doing this or needs an investigation. Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing.

Comments

@gwjulian
Copy link

Windows Terminal version

1.16.10261.0

Windows build number

10.0.19044.0

Other Software

NVIM v0.9.0
Build type: RelWithDebInfo
LuaJIT 2.1.0-beta3

Steps to reproduce

With Cascadia code or Recursive type mono open a neovim session with an italic-support theme/colorscheme

Expected Behavior

Italic characters should not be stripped or shown incomplete

Actual Behavior

Italic letters are cut/stripped or
image

@gwjulian gwjulian added Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels Apr 27, 2023
@zadjii-msft
Copy link
Member

Wadda ya know, this was just fixed in #14959.

/dup #9381

@zadjii-msft zadjii-msft closed this as not planned Won't fix, can't repro, duplicate, stale Apr 27, 2023
@microsoft-github-policy-service
Copy link
Contributor

Hi! We've identified this issue as a duplicate of another one that already exists on this Issue Tracker. This specific instance is being closed in favor of tracking the concern over on the referenced thread. Thanks for your report!

@microsoft-github-policy-service microsoft-github-policy-service bot added Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing. and removed Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels Apr 27, 2023
@gwjulian
Copy link
Author

@zadjii-msft I still see text being cut despite changing text aliasing like the dup suggest.
But, I don't know, do I need to update my terminal? or rather wait for the update to come?
thanks by the way

@lhecker
Copy link
Member

lhecker commented Apr 27, 2023

You'll likely have to wait for the update to be released. It'll first ship in Windows Terminal Preview 1.18. We are nearing a release, but we don't have an exact release timeline yet, because 1.18 will contain a massive overhaul of a lot of fundamental components (the entire UI setup to facilitate tab tear-out & text rendering being rewritten from scratch).

@lhecker
Copy link
Member

lhecker commented Apr 27, 2023

With Cascadia code or Recursive type mono open a neovim session with an italic-support theme/colorscheme

Although I should mention that both you and #9381 are wrong about this, if I may be so frank. 😅 Yes, the issue does happen for Recursive Mono and FiraCode, but it will not happen for Cascadia Code. Unless you forgot to install its italic variant. This is how Cascadia Code with the proper italic variant looks like in 1.16.10262.0, for reference:
image

@gwjulian
Copy link
Author

@lhecker Thanks for the reply.
Yes, In fact I'm using the nerd font patched cascadia code so that might be the issue as well.
I'll be waiting the update then.

@lhecker
Copy link
Member

lhecker commented Apr 27, 2023

For a bit of a technical background, if you're using Caskaydia Cove: That font doesn't ship with our (Cascadia Code's) italic variant, which results in the text renderer using "simulated italics", which "lean" so much to the side that they end up being outside of the cell and get clipped off. You could use Delugia Code instead which does ship with the proper italics. I'm using Delugia myself, especially since Caskaydia Cove has many more subtle issues in general (as well as all other official nerd fonts unfortunately).

@gwjulian
Copy link
Author

gwjulian commented Apr 27, 2023

@lhecker I actually prefer using Recursive Duotone (for the mix of casual and semicasual styles), but Delugia seems to be good, I'm gonna be trying it out.
Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue-Bug It either shouldn't be doing this or needs an investigation. Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing.
Projects
None yet
Development

No branches or pull requests

3 participants