Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transparency doesn't work when background colour is not the default #15345

Closed
bzzrak opened this issue May 13, 2023 · 5 comments
Closed

Transparency doesn't work when background colour is not the default #15345

bzzrak opened this issue May 13, 2023 · 5 comments
Labels
Issue-Bug It either shouldn't be doing this or needs an investigation. Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing.

Comments

@bzzrak
Copy link

bzzrak commented May 13, 2023

Windows Terminal version

1.17.1023

Windows build number

10.0.22621.1702

Other Software

cmd.exe, vim...

Steps to reproduce

Run color f0 in cmd.exe, or for example :colo peachpuff in Vim. Anything that changes the background colour

Expected Behavior

Transparency works like in Conhost
image

Actual Behavior

Transparency doesn't work, except on the right edge of the window
image

I've tried completely resetting my settings too, doesn't help.

@bzzrak bzzrak added Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels May 13, 2023
@j4james
Copy link
Collaborator

j4james commented May 13, 2023

If I've understood you correctly, I think the feature you want is tracked in #5145.

@bzzrak
Copy link
Author

bzzrak commented May 13, 2023

That doesn't seem like what I'm talking about. That issue is about blending an image background with the default background colour.
I'm talking about the fact that transparency just doesn't work when the background colour isn't the default

@j4james
Copy link
Collaborator

j4james commented May 13, 2023

I think the underlying issue is the same though - the way the transparency is currently implemented, it only applies to the default background color. In your case that means you can't see the desktop. In their case, they can't see their background image. Both case would likely be addressed in the same way.

I might be wrong, though. One the core devs will be able to confirm one way or the other.

@lhecker
Copy link
Member

lhecker commented May 16, 2023

Yep, I agree. This is fundamentally the same issue, given the way we've implemented background colors. Thanks for reporting this however! If you can, please upvote the other issue. We do use the number of upvotes on issues to determine what features to implement next from time to time.

/dup #5145

@microsoft-github-policy-service
Copy link
Contributor

Hi! We've identified this issue as a duplicate of another one that already exists on this Issue Tracker. This specific instance is being closed in favor of tracking the concern over on the referenced thread. Thanks for your report!

@microsoft-github-policy-service microsoft-github-policy-service bot added Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing. and removed Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels May 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue-Bug It either shouldn't be doing this or needs an investigation. Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing.
Projects
None yet
Development

No branches or pull requests

3 participants