Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using a separate config file or path to save ColorSchemes.json #15627

Closed
kylinholmes opened this issue Jun 28, 2023 · 3 comments
Closed

Using a separate config file or path to save ColorSchemes.json #15627

kylinholmes opened this issue Jun 28, 2023 · 3 comments
Labels
Area-Settings Issues related to settings and customizability, for console or terminal Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. Needs-Tag-Fix Doesn't match tag requirements Product-Terminal The new Windows Terminal. Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing.

Comments

@kylinholmes
Copy link

Description of the new feature/enhancement

Many users like to change their preference of terminal, and the current way of setting and store ColorSchemes.json is a litte bit unconverience.

Now, if I wanna to try a NewStyle, I only need to copy content and paste it into the section of schemes in settings.json.
However, when I downloading a collection of shcemes, the way above is unconfortable, cause I don't wanna to repeat it like 100 times.

Whats more, iTerm2 have a quicker way to get the preview of scheme.

Proposed technical implementation details (optional)

My suggestion is using a specific dir like ~/.WindowsTeriminal/colors/ to save all ColorSchemes.json, which will more easier to download, to add.

When launching WindowsTerminal, reading all *.json in the above dir automaticlly.
which will also be easier to find or udpate content in each *.json

@kylinholmes kylinholmes added the Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. label Jun 28, 2023
@microsoft-github-policy-service microsoft-github-policy-service bot added Needs-Tag-Fix Doesn't match tag requirements Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels Jun 28, 2023
@carlos-zamora
Copy link
Member

Thanks for filing! A few notes:

  • Saving settings to a different location is something we've talked about in the past. I can't find an open issue on it though, so I'll just use this to track it for now.
  • Fragments are a solution to this problem, actually! You can introduce new color schemes via JSON fragment extensions. Read more about it here: https://learn.microsoft.com/en-us/windows/terminal/json-fragment-extensions
  • Overall, we want to invest in the Settings UI to make this a non-issue. We're tracking all our major investments in the Settings UI here: Epic: Settings UI v2 #10000

@carlos-zamora carlos-zamora added Area-Settings Issues related to settings and customizability, for console or terminal Product-Terminal The new Windows Terminal. and removed Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Jun 28, 2023
@carlos-zamora carlos-zamora added this to the Backlog milestone Jun 28, 2023
@zadjii-msft
Copy link
Member

Saving settings to a different location is something we've talked about in the past. I can't find an open issue on it though

Ah, we're tracking this in #2933 actually. At least, that's the place I've duped this all to in the past - for both layering beyond just fragments, but also roaming the settings. We can consolidate this.

/dup #2933

@zadjii-msft zadjii-msft closed this as not planned Won't fix, can't repro, duplicate, stale May 10, 2024
Copy link
Contributor

Hi! We've identified this issue as a duplicate of another one that already exists on this Issue Tracker. This specific instance is being closed in favor of tracking the concern over on the referenced thread. Thanks for your report!

@microsoft-github-policy-service microsoft-github-policy-service bot removed this from the Backlog milestone May 10, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing. Needs-Tag-Fix Doesn't match tag requirements labels May 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Settings Issues related to settings and customizability, for console or terminal Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. Needs-Tag-Fix Doesn't match tag requirements Product-Terminal The new Windows Terminal. Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing.
Projects
None yet
Development

No branches or pull requests

3 participants