-
Notifications
You must be signed in to change notification settings - Fork 8.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
could we provide a legacy font render option like windows console host style? #15710
Comments
I'm intending to implement such an option for #14165. As a stop gap you can convert the font size of Consolas from conhost to Windows Terminal by dividing by 1.5611979167. A font size of 16 in conhost for instance corresponds to a font size of 10.24854045 in Windows Terminal. It should then look quite similar if not identical. 🙂 |
@237dmitry Is there a reason you use |
also could you try consolas font? I guess different font may have different effect. |
@zhishi Ah if you want to also replicate the exact "cell size" of conhost then you'll have to do one more thing... If you install Windows Terminal Preview (version 1.18) and open the settings.json file, then next to your font "size" entry you can add this: {
"profiles":
{
"defaults":
{
"font":
{
"face": "Consolas",
"size": 10.24854045,
"cellHeight": "16px"
}
}
}
} There's also a matching "cellWidth" option. The argument is a CSS string and it supports pt, px, percentages, etc. The 10.24854045 as font size is correct (I've just tested it). You have to do this, because right now the algorithm for determining the line height and cell width is slightly different from GDI as used in conhost. As part of #14165 I'll try to make the two match as closely as possible (without sacrificing accuracy). But there will always be a mismatch at certain font sizes and display scales, most importantly because GDI doesn't even use Edit, Note to self: Will tag needs-discussion to learn more about tab title heights. |
cool, thanks for the followup. I wonder could the green arrow size also caused by the integers? I'll give it a try. |
I do not like Atlas as it is rendering some double place symbols incorrectly.
There are many terminal alternatives. Conhost is good also, if it could hide scrollbar and could clickable hyperlinks... |
@zhishi No, not really. When you use conhost, the font determines how many columns a glyph occupies. Since the arrow is wide it occupies 2 columns. But Windows Terminal works more like most other terminals, where the Unicode standard UAX#11 determines how wide glyphs are. And there the arrow is considered 1 column wide.
@237dmitry I'm also planning to make AtlasEngine the default in conhost at some point in the distant future. If you could tell us what it handles poorly, I'll fix it as soon as possible. 🙂 |
Hmm, I tried turning on Atlas and it really works better than before. And I've been using 1.18 since its release. I guess I got so used to the fact that the Atlas Engine did not display some characters well that I was biased towards it and always turned it off. I apologize for the unfounded criticism. Now it really is much better. |
For compact title bars you can follow this issue #5911. |
Hi! We've identified this issue as a duplicate of another one that already exists on this Issue Tracker. This specific instance is being closed in favor of tracking the concern over on the referenced thread. Thanks for your report! |
Description of the new feature/enhancement
Currently I'm doing coding work mostly on remote host via ssh, and I liked the new windows terminal a lot. However there is one thing caused me to go back to the old windows console host. There is minor difference between the new windows terminal and the old windows console host on font rendering style, but it just annoys me enough to not using windows terminal.
As I know font show different size on windows terminal and windows console host. For example when I use consolas font, I need choose size 11 in windows terminal to match the size 16 in windows console host:
And that size 11 still can't generate same width and height like the size 16 in windows console host, it has a little bit wider and taller space between characters. which results in less lines and text showed in my text editor, for example you can see below picture showed the gap of lines become bigger and bigger between the windows console host (background) and windows terminal:
Another problem showed in above picture is that green arrow in left side (if you are using zsh you should familiar with that arrow). The windows terminal for some reason render it much smaller than normal size, which just give a non-consistence overall view.
So overall I just like windows console host more for the compact and consistence render style (it also match iterm2 style better), but I guess it's not hard to add same render option in windows terminal since they share a lot code base. maybe just provide a checkbox with legacy render style?
The text was updated successfully, but these errors were encountered: