Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

REP corrupts some Unicode characters (emoji) #15751

Closed
dgl opened this issue Jul 24, 2023 · 2 comments
Closed

REP corrupts some Unicode characters (emoji) #15751

dgl opened this issue Jul 24, 2023 · 2 comments
Labels
Issue-Bug It either shouldn't be doing this or needs an investigation. Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing.

Comments

@dgl
Copy link

dgl commented Jul 24, 2023

Windows Terminal version

1.18.1462.0

Windows build number

10.0.25300.1000

Other Software

No response

Steps to reproduce

Repeating some emoji with an escape sequence results in mojibake. In WSL or any Linux:

$ printf '\e[6n💓\e[1b\e[6n\n';cat
💓�
^[[4;1R^[[4;4R^C

Expected Behavior

On a recent xterm (run with xterm -fa Mono -fs 14, to get TrueType fonts) the output is:

$ printf '\e[6n💓\e[1b\e[6n\n';cat
💓💓
^[[4;1R^[[4;5R^C

Windows Terminal also behaves as expected for ✅, this only affects some emoji characters.

Actual Behavior

As above, the second character is corrupted, see screenshot too.

image
@dgl dgl added Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels Jul 24, 2023
@lhecker
Copy link
Member

lhecker commented Jul 24, 2023

Hey! This issue is a duplicate of #15390. 🙂 I believe #15541 made it possible to fix the issue for this particular escape sequence. I'm not entirely sure which part in our code base doesn't handle surrogate pairs, etc., but I suspect it can be discovered by setting a breakpoint on AdeptDispatch::_FillRect.

/dup #15390

@microsoft-github-policy-service
Copy link
Contributor

Hi! We've identified this issue as a duplicate of another one that already exists on this Issue Tracker. This specific instance is being closed in favor of tracking the concern over on the referenced thread. Thanks for your report!

@microsoft-github-policy-service microsoft-github-policy-service bot added Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing. and removed Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels Jul 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue-Bug It either shouldn't be doing this or needs an investigation. Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing.
Projects
None yet
Development

No branches or pull requests

2 participants