-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Latest compilers emit a ton of C4996 warnings as errors #16000
Comments
Related: fmtlib/fmt#3540
|
Yep we should probably just update that. Thanks! |
Related: #15855 I am committing to not updating our checked-in dependencies until we have a Governance-clean pipeline for doing so :) |
BTW I just noticed: Happy round-issue-number to you! It turns out that the upgrade is a significant pain in the butt, because
I started working on this in https://github.com/microsoft/terminal/tree/dev/lhecker/16000-fmt-update |
I am uncomfortable with the premier C++ formatting library removing support for an entire platform like that. Considering that Windows predominantly uses wide strings, that makes it nearly unfit for purpose. Do you happen to have any links to docs about them explicitly dropping support? |
Hey! I said "largely removed", not "dropped". 😄 And I meant it in the context of our project which uses
The same is true for I don't know which commit(s) removed either of the two features, because there's no commit in |
I finished fixing all issues and as it turns out, the format(RS_(...), ...) which now need to be format(fmt::runtime(RS_(...)), ...) because it now does compile time format checks even without |
Windows Terminal version
main @ 2e91e9c
Windows build number
10.0.22621.0
Other Software
Visual Studio
Version 17.8.0 Preview 3.0 [34118.359.main]
Steps to reproduce
Expected Behavior
No errors
Actual Behavior
1,123 C4996 warnings as errors. e.g.:
The text was updated successfully, but these errors were encountered: