Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Acrylic background not applied at startup #16052

Open
davidegiacometti opened this issue Sep 28, 2023 · 12 comments
Open

Acrylic background not applied at startup #16052

davidegiacometti opened this issue Sep 28, 2023 · 12 comments
Assignees
Labels
Area-Windowing Window frame, quake mode, tearout Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Repro We can't figure out how to make this happen. Please help find a simplified repro. Priority-2 A description (P2) Product-Terminal The new Windows Terminal.

Comments

@davidegiacometti
Copy link
Contributor

Windows Terminal version

1.18.2681.0

Windows build number

10.0.19045.0

Other Software

No response

Steps to reproduce

Just open Terminal.

In the following gif I am just opening Terminal from the taskbar icon and closing it with ALT+F4 multiple times in a row.
Acrylic background is applied only on the first startup (but it's random).

Terminal

Expected Behavior

Acrylic background applied

Actual Behavior

Acrylic background sometimes is not applied

@davidegiacometti davidegiacometti added Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels Sep 28, 2023
@zadjii-msft
Copy link
Member

Here's a possibly goofy question - those times when it starts up without acrylic applied, if you just start typing on the keyboard, does that show up in the Terminal/? My hypothesis is that this is similar to #15479.

Are you launching the Terminal by shift+clicking on the taskbar?

Are there any other terminals running, or are you using compatibility.allowHeadless?

@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something label Sep 28, 2023
@davidegiacometti
Copy link
Contributor Author

davidegiacometti commented Sep 28, 2023

Here's a possibly goofy question - those times when it starts up without acrylic applied, if you just start typing on the keyboard, does that show up in the Terminal/? My hypothesis is that this is similar to #15479.

The windows does have focus, I can type but in order to see the acrylic background I have to focus another windows and go back to the Terminal one.

Are you launching the Terminal by shift+clicking on the taskbar?

Just a single click.
Behavior is the same with SHIFT+Click

Are there any other terminals running, or are you using compatibility.allowHeadless?

Just one single Terminal window.
I don't have compatibility.allowHeadless in the settings JSON.

EDIT: note that I have never experienced the focus issue you have linked and this behavior with acrylic has started yesterday after installing 1.18.2681.0.

@microsoft-github-policy-service microsoft-github-policy-service bot added Needs-Attention The core contributors need to come back around and look at this ASAP. and removed Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something labels Sep 28, 2023
@zadjii-msft
Copy link
Member

Okay my dumb hypothesis is that the window has foreground, but isn't activated for some reason. I'm not even sure that's possible but user32 is dark and full of terrors.

Can you try out the following theme?

"theme": "Test",
"themes":
[
    {
        "name": "Test",
        "tab":
        {
            "background": "terminalBackground",
            "showCloseButton": "always",
            "unfocusedBackground": "#00000000"
        },
        "tabRow":
        {
            "background": "#00ff00ff",
            "unfocusedBackground": "#ff0000ff"
        },
        "window":
        {
            "applicationTheme": "dark",
        }
    },
]

That should aggressively change the color of the titlebar, depending on if the window is activated or not. When you first launch the terminal (when acrylic isn't working), which color do you get?

@zadjii-msft zadjii-msft added Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something and removed Needs-Attention The core contributors need to come back around and look at this ASAP. labels Oct 11, 2023
@davidegiacometti
Copy link
Contributor Author

After launch
image

After switching back to Terminal
image

It becomes red when Terminal is unfocused.

@microsoft-github-policy-service microsoft-github-policy-service bot added Needs-Attention The core contributors need to come back around and look at this ASAP. and removed Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something labels Oct 11, 2023
@SmileEX
Copy link

SmileEX commented Oct 18, 2023

I have the same problem. Is there any solution

@zadjii-msft
Copy link
Member

10.0.19045.0

In the following gif I am just opening Terminal from the taskbar icon and closing it with ALT+F4 multiple times in a row.
Acrylic background is applied only on the first startup (but it's random).

Hmm. Okay, here's another dumb question. Is there any other terminal window running when you're doing this? Or even more accurately, any other Terminal process? I wonder if the acrylic isn't getting appropriately applied when we reheat an old window (a la #15424). Like, the theory of that case is

  • You open two Terminal windows ("A" and "B")
  • Close B
  • Open another window, "C"
    • this reuses B's thread)
    • C opens without acrylic applied.

another observation here is that acrylic in the tab row was applied, so it's not just like, a rendering bug. This is more than just the control that's not acrylic, it's acrylic as a whole.


Is there any solution

Not yet. The newly re-written acrylic in Terminal Preview (to allow unfocused acrylic) might help here?

@zadjii-msft zadjii-msft removed the Needs-Attention The core contributors need to come back around and look at this ASAP. label Oct 18, 2023
@davidegiacometti
Copy link
Contributor Author

davidegiacometti commented Oct 18, 2023

@zadjii-msft no other process or windows running. I have also experienced this the first time I started Terminal after a reboot (note that auto startup is disabled).
Mmm.. I don't think acrylic is applied when the bug is hit (first post gif).

Is this that hard to reproduce for the team?
A few weeks ago I tried to debug it in a local build (without success 😭) and with the unfocused acrylic I was able to see the issue only in the title bar sometimes.

@bingloo
Copy link

bingloo commented Oct 19, 2023

I also had this issue after the Windows 11 app store update yesterday. default set "cmd", When running the bat file, reproduce this issue 100%.
version: 1.18.2822.0

@carlos-zamora carlos-zamora added Needs-Repro We can't figure out how to make this happen. Please help find a simplified repro. Product-Terminal The new Windows Terminal. Priority-2 A description (P2) Area-Windowing Window frame, quake mode, tearout and removed Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels Oct 24, 2023
@carlos-zamora carlos-zamora added this to the Terminal v1.20 milestone Oct 24, 2023
@tavrez
Copy link

tavrez commented Feb 6, 2024

This looks fixed in v1.19.10302.0 for me, however tab row is still affected (probably related to #16661)

@revanmj
Copy link

revanmj commented Feb 11, 2024

This looks fixed in v1.19.10302.0 for me, however tab row is still affected (probably related to #16661)

Well, I got that issue since this update and never had it before.

Same as above - just launch the Terminal (in my case from Start menu) and it doesn't have Acrylic background until I switch to a different window and back (once in a while just switching to different window will apply Acrylic).

So far it is 100% reproducible, ever since installing v1.19.10302.0 the app never launched with Acrylic applied right from the launch. Have this issue on two computers (laptop and desktop), both with Win11 23H2.

@revanmj
Copy link

revanmj commented Feb 20, 2024

This looks fixed in v1.19.10302.0 for me, however tab row is still affected (probably related to #16661)

Well, I got that issue since this update and never had it before.

Same as above - just launch the Terminal (in my case from Start menu) and it doesn't have Acrylic background until I switch to a different window and back (once in a while just switching to different window will apply Acrylic).

So far it is 100% reproducible, ever since installing v1.19.10302.0 the app never launched with Acrylic applied right from the launch. Have this issue on two computers (laptop and desktop), both with Win11 23H2.

OK, turns out that latest version started somehow interfering with Mica for Everyone. After I added Terminal process to the blocklist in Mica for Everyone, Acrylic is now properly applied on startup (this was not needed before latest stable).

@zadjii-msft
Copy link
Member

you know what? this may be related to #16745

Another user reported that things got better after adding "compatibility.enableUnfocusedAcrylic": false to the global settings (i.e. next to useAcrylicInTabRow) (then rebooting the Terminal).

@zadjii-msft zadjii-msft self-assigned this Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Windowing Window frame, quake mode, tearout Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Repro We can't figure out how to make this happen. Please help find a simplified repro. Priority-2 A description (P2) Product-Terminal The new Windows Terminal.
Projects
None yet
Development

No branches or pull requests

7 participants