Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Terminal renders gaps in between some lines #1626

Closed
ocalvo opened this issue Jun 25, 2019 · 6 comments
Closed

Terminal renders gaps in between some lines #1626

ocalvo opened this issue Jun 25, 2019 · 6 comments
Labels
Area-Rendering Text rendering, emoji, complex glyph & font-fallback issues Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-3 A description (P3) Product-Terminal The new Windows Terminal. Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing.
Milestone

Comments

@ocalvo
Copy link
Contributor

ocalvo commented Jun 25, 2019

Environment

Windows 10 19H1

Windows build number: 10.0.18362.175
Windows Terminal version (if applicable):

Any other software?
[ZtreeWin](http://www.ztree.com/html/ztreewin.htm)

Steps to reproduce

1 - Install ZtreeWin, or PowerShell PowerTab
2 - Make Terminal Window large
3 - Execute ztw or [TAB] in PowerShell with PowerTab enabled

Expected behavior

PowerTab Good

ZtwOLD

Actual behavior

PowerTab Bad

ZtwNEW

There are multiple horizontal lines that should not be there.

@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Jun 25, 2019
@ocalvo ocalvo changed the title ZtreeWin GOLD does not render correctly PowerTab/ZtreeWin and other console mode GUI does not render correctly Jun 27, 2019
@miniksa miniksa added Area-Rendering Text rendering, emoji, complex glyph & font-fallback issues Issue-Bug It either shouldn't be doing this or needs an investigation. Product-Terminal The new Windows Terminal. and removed Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels Jun 27, 2019
@ghost ghost removed the Needs-Tag-Fix Doesn't match tag requirements label Jun 27, 2019
@miniksa miniksa changed the title PowerTab/ZtreeWin and other console mode GUI does not render correctly Terminal renders gaps in between some lines Jun 27, 2019
@miniksa
Copy link
Member

miniksa commented Jun 27, 2019

This is sort of like #404, but my psychic debugging says this is floating point measuring of lines going awry and it might be really smart to just wholesale move to GDI measuring like #1298 suggested.

@ocalvo
Copy link
Contributor Author

ocalvo commented Jun 28, 2019

I think there are 2 issues here, one that is dependent on DPI.

For example ZTW at 200 DPI shows like these:
Ztw DPI200

  • Notice the horizontal lines
  • Notice the vertical lines are not continuous

For ZTW at 100 DPI:
Ztw DPI100

  • Notice that the horizontal lines are fixed.
  • But the vertical lines are still not continuous.

Baseline:
ZtwOLD

@thomaslevesque
Copy link

I see the same thing with display scaling at 125% or 150%. Works fine at 100%.
Particularly annoying when using oh-my-posh, or anything that relies on fonts with Powerline glyphs

@wmcbrine
Copy link

wmcbrine commented Nov 4, 2019

Vertical gaps also sometimes occur. I am using 125% scaling.

@zadjii-msft zadjii-msft added the Priority-3 A description (P3) label Jan 22, 2020
@DHowett-MSFT
Copy link
Contributor

/dup #3626

@ghost
Copy link

ghost commented Jan 28, 2020

Hi! We've identified this issue as a duplicate of another one that already exists on this Issue Tracker. This specific instance is being closed in favor of tracking the concern over on the referenced thread. Thanks for your report!

@ghost ghost closed this as completed Jan 28, 2020
@ghost ghost added the Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing. label Jan 28, 2020
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Rendering Text rendering, emoji, complex glyph & font-fallback issues Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-3 A description (P3) Product-Terminal The new Windows Terminal. Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing.
Projects
None yet
Development

No branches or pull requests

6 participants