Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows terminal crash #16573

Closed
NeilMacMullen opened this issue Jan 19, 2024 · 10 comments
Closed

Windows terminal crash #16573

NeilMacMullen opened this issue Jan 19, 2024 · 10 comments
Labels
Area-DefApp Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Attention The core contributors need to come back around and look at this ASAP. Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something Needs-Repro We can't figure out how to make this happen. Please help find a simplified repro. No-Recent-Activity This issue/PR is going stale and may be auto-closed without further activity. Priority-1 A description (P1) Product-Terminal The new Windows Terminal. Severity-Crash Crashes are real bad news.

Comments

@NeilMacMullen
Copy link

Windows Terminal version

1.18.3181.0

Windows build number

10.0.22631.0

Other Software

Custom application

Steps to reproduce

Unclear - still under investigation. Possible that application is experiencing OOM exception or generating large amounts or console output

Expected Behavior

Application should be terminated but terminal should keep running

Actual Behavior

We use Windows Terminal to spawn a number of powershell scripts in separate terminal processes. (The "master" script that does this simply invokes... Start-Process -windowstyle normal powershell -ArgumentList $arglist)

The poweshell scripts run some custom CLI commands periodically (i.e. they run the command then sleep for a few hours).

This results in a number of tiled windows....
image

Recently we have found instances where Terminal appears to crash in a way that the entire process is killed - i.e,. all spawned windows disappear. The trigger appears to be a fault in one of the CLI applications (possibly out-of-memory) but we would expect the behaviour in this case for the application to be killed, not the entire Terminal process. (Happy to close though if this is "expected" behaviour.)

Unfortunately we don't have a lot of post-mortem information at this time... EventLog shows an Application Error for Terminal...

Faulting application name: WindowsTerminal.exe, version: 1.18.2311.14001, time stamp: 0x6553b19e
Faulting module name: ntdll.dll, version: 10.0.22621.2506, time stamp: 0xbced4b82
Exception code: 0xc0000409
Fault offset: 0x00000000000a7d18
Faulting process ID: 0x0x5714
Faulting application start time: 0x0x1DA491FE3458FB2
Faulting application path: C:\Program Files\WindowsApps\Microsoft.WindowsTerminal_1.18.3181.0_x64__8wekyb3d8bbwe\WindowsTerminal.exe
Faulting module path: C:\WINDOWS\SYSTEM32\ntdll.dll
Report ID: 2082cf3e-3952-4061-bfe1-e6bc7aa7bef6
Faulting package full name: Microsoft.WindowsTerminal_1.18.3181.0_x64__8wekyb3d8bbwe
Faulting package-relative application ID: App
@NeilMacMullen NeilMacMullen added Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels Jan 19, 2024
Copy link

Hi I'm an AI powered bot that finds similar issues based off the issue title.

Please view the issues below to see if they solve your problem, and if the issue describes your problem please consider closing this one and thumbs upping the other issue to help us prioritize it. Thank you!

Closed similar issues:

Note: You can give me feedback by thumbs upping or thumbs downing this comment.

@zadjii-msft
Copy link
Member

Hmm. That Report ID isn't on the backend, at least not that I can find it. Did you happen to see a Bucket ID anywhere? Otherwise, reproing this with Feedback Hub is probably the easiest way for us to get to the crash dump: /feedback

@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something label Jan 19, 2024
@NeilMacMullen
Copy link
Author

NeilMacMullen commented Jan 19, 2024

Hmm - I can't find a "bucketid" anywhere but in case it's helpful here are a couple more reports of what look like the same problem....


Faulting application name: WindowsTerminal.exe, version: 1.18.2311.14001, time stamp: 0x6553b19e
Faulting module name: unknown, version: 0.0.0.0, time stamp: 0x00000000
Exception code: 0xc0000005
Fault offset: 0x000000c5d2eff8a8
Faulting process ID: 0x0x63D4
Faulting application start time: 0x0x1DA4ABDD38785BE
Faulting application path: C:\Program Files\WindowsApps\Microsoft.WindowsTerminal_1.18.3181.0_x64__8wekyb3d8bbwe\WindowsTerminal.exe
Faulting module path: unknown
Report ID: 0cb28a16-b300-490e-84b2-69e2eacda35f
Faulting package full name: Microsoft.WindowsTerminal_1.18.3181.0_x64__8wekyb3d8bbwe
Faulting package-relative application ID: App
Faulting application name: WindowsTerminal.exe, version: 1.18.2311.14001, time stamp: 0x6553b19e
Faulting module name: unknown, version: 0.0.0.0, time stamp: 0x00000000
Exception code: 0xc0000005
Fault offset: 0x0000005dd9cff238
Faulting process ID: 0x0x66C
Faulting application start time: 0x0x1DA485787FEEE27
Faulting application path: C:\Program Files\WindowsApps\Microsoft.WindowsTerminal_1.18.3181.0_x64__8wekyb3d8bbwe\WindowsTerminal.exe
Faulting module path: unknown
Report ID: 53e775d3-23ed-4aab-ad06-2c591707647a
Faulting package full name: Microsoft.WindowsTerminal_1.18.3181.0_x64__8wekyb3d8bbwe
Faulting package-relative application ID: App

Unfortunately I haven't yet found a way to reliably reproduce this on demand but will continue investigating.

@microsoft-github-policy-service microsoft-github-policy-service bot added Needs-Attention The core contributors need to come back around and look at this ASAP. and removed Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something labels Jan 19, 2024
@carlos-zamora carlos-zamora added Severity-Crash Crashes are real bad news. Product-Terminal The new Windows Terminal. and removed Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Attention The core contributors need to come back around and look at this ASAP. labels Jan 24, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Tag-Fix Doesn't match tag requirements label Jan 24, 2024
@carlos-zamora carlos-zamora added Needs-Repro We can't figure out how to make this happen. Please help find a simplified repro. Area-DefApp and removed Needs-Tag-Fix Doesn't match tag requirements labels Jan 24, 2024
@carlos-zamora carlos-zamora added the Priority-1 A description (P1) label Jan 24, 2024
@zadjii-msft
Copy link
Member

We've got a theory here that this might be the same thing that #16575 is supposed to fix. We're planning on merging that and quickly pushing an updated build Soon. We should be able to give you a build with some fixes and tease out if that's the actual same root cause or not.

@NeilMacMullen
Copy link
Author

Interesting. In typical fashion the system has now been running fine for 4 days without re-exhibiting the problem after I added extra diagnostics to try and track down the precipitating event. I couldn't quite follow the discussion in the referenced bug but looks like this is triggered by a (heavily multi-threaded ?) app crash? That might well be consistent with what we're doing.

@zadjii-msft
Copy link
Member

If this is cool with you, I'm gonna close this out for housekeeping. If you ever see it again, we can always reopen ☺️

@zadjii-msft zadjii-msft closed this as not planned Won't fix, can't repro, duplicate, stale Feb 6, 2024
@zadjii-msft zadjii-msft added the Resolution-No-Repro We couldn't get this to happen, or it stopped happening entirely. label Feb 6, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added Needs-Tag-Fix Doesn't match tag requirements labels Feb 6, 2024
@NeilMacMullen
Copy link
Author

hmm- I've seen it 4 or 5 times since but unfortunately it's very difficult to reproduce on demand - normally I come back to the machine after a couple of days and notice it has occurred. I'm happy to try out whichever build contains the fix for #16575 though and can let you know if that makes it go away.

@zadjii-msft
Copy link
Member

Gotcha. Okay I'll reopen then. The 1.19 Stable release should have that fix in it - lmk if it comes back? (or, I'll have the bot re-close if it has just gone away ☺️ )

@zadjii-msft zadjii-msft reopened this Feb 7, 2024
@zadjii-msft zadjii-msft removed the Resolution-No-Repro We couldn't get this to happen, or it stopped happening entirely. label Feb 7, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot removed the Needs-Tag-Fix Doesn't match tag requirements label Feb 7, 2024
@zadjii-msft zadjii-msft added Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something Needs-Tag-Fix Doesn't match tag requirements labels Feb 7, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot removed the Needs-Tag-Fix Doesn't match tag requirements label Feb 7, 2024
@NeilMacMullen
Copy link
Author

Great - I've upgraded to Windows Terminal Preview Version: 1.20.10303.0. Fingers crossed it's gone away but if not I'll dig in a bit further and let you know of any evidence I can collect.

@microsoft-github-policy-service microsoft-github-policy-service bot added Needs-Attention The core contributors need to come back around and look at this ASAP. and removed Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something labels Feb 7, 2024
@zadjii-msft zadjii-msft added the Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something label Feb 8, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added the No-Recent-Activity This issue/PR is going stale and may be auto-closed without further activity. label Feb 12, 2024
Copy link
Contributor

This issue has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for 4 days. It will be closed if no further activity occurs within 3 days of this comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-DefApp Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Attention The core contributors need to come back around and look at this ASAP. Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something Needs-Repro We can't figure out how to make this happen. Please help find a simplified repro. No-Recent-Activity This issue/PR is going stale and may be auto-closed without further activity. Priority-1 A description (P1) Product-Terminal The new Windows Terminal. Severity-Crash Crashes are real bad news.
Projects
None yet
Development

No branches or pull requests

3 participants