Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change 'Settings' to 'Settings file' #1668

Closed
mcpiroman opened this issue Jun 27, 2019 · 7 comments
Closed

Change 'Settings' to 'Settings file' #1668

mcpiroman opened this issue Jun 27, 2019 · 7 comments
Labels
Area-UserInterface Issues pertaining to the user interface of the Console or Terminal Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. Product-Terminal The new Windows Terminal. Resolution-Won't-Fix We're just really obstinate about this. There's probably a good reason.

Comments

@mcpiroman
Copy link
Contributor

mcpiroman commented Jun 27, 2019

Since a lot of people have issues with what does the "Settings" button, maybe it's better to clarify it by temporarily changing it to "Settings file" or "Open settings file".

@mcpiroman mcpiroman added the Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. label Jun 27, 2019
@ghost ghost added Needs-Tag-Fix Doesn't match tag requirements Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels Jun 27, 2019
@andrewbaker-uk
Copy link

Or even better a settings window which provides the same options as editing the settings file. I disagree with changing the name though. "Settings file" or "Open settings file" is too wordy. Settings on its own keeps it simple

@mcpiroman
Copy link
Contributor Author

@theterminator3000, Yes of course, there will eventually be a settings window, such as users expect. But for a time it is not, it might be better to call the button after what it is actually doing i.e. opening settings file ( what apparently isn't what users expect, see issues like #1580 or #1664).

@yidhoe
Copy link

yidhoe commented Jun 27, 2019

Hey guys \ girls,

This all sounds great, however I would like to add a request to Keep the "Settings File" in the long run too, even if you can't edit it from here.

I manage over 1000 machine and it would be very useful to be able to deploy setting to all of these so they terminals are reconfigured as required.

So for this reason long term I would like to request the ability to configure it by file or through the settings window.

Maybe the there could be an Import \ Export settings option too for those who aren't scripting everything but do want to be able to have a standard set of settings.

Probably already on your list but just in case.

*Keep up the good work, massive improvement on the current MS Terminal Already! :)

@JushBJJ
Copy link

JushBJJ commented Jun 27, 2019

I'm sure you're talking about #1567

@yidhoe
Copy link

yidhoe commented Jun 27, 2019

No actuallky.

Personally the location does not fuss me as it would be scripted anyway, I just want to ensure that the settings remain in a fil we can easily edit and copy between machines in the long run.

As nice as a GUI is having both options is always better. :)

@JushBJJ
Copy link

JushBJJ commented Jun 27, 2019

Then you probably mean #1564

@miniksa
Copy link
Member

miniksa commented Jun 27, 2019

We're not changing the name of the button right now for the interim state. It's an alpha product.

Our intent is to have a Settings UI and we will certainly make the file still accessible or more accessible than it is now per the linked issues by @JushBJJ.

Resolving.

@miniksa miniksa closed this as completed Jun 27, 2019
@miniksa miniksa added Resolution-Won't-Fix We're just really obstinate about this. There's probably a good reason. Area-UserInterface Issues pertaining to the user interface of the Console or Terminal Product-Terminal The new Windows Terminal. and removed Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels Jun 27, 2019
@ghost ghost removed the Needs-Tag-Fix Doesn't match tag requirements label Jun 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-UserInterface Issues pertaining to the user interface of the Console or Terminal Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. Product-Terminal The new Windows Terminal. Resolution-Won't-Fix We're just really obstinate about this. There's probably a good reason.
Projects
None yet
Development

No branches or pull requests

5 participants