Terminal does not remember session, opens with settings

[krzysdz]

Windows Terminal version

67ae9f6

Windows build number

10.0.19045.4170

Other Software

No response

Steps to reproduce

1. Make sure that a default profile exists and Terminal is set up to open windows from previous sessions when started.
2. Open at least 1 non-settings tab
3. Close the window
4. Open Terminal again

Expected Behavior

The Terminal opens with the same tabs that were open when the window was closed.

Actual Behavior

Always only the settings tab is opened.

2024-04-05.00-53-56.mp4

Probably related to #16998. The version that previously worked for me was 9f3dbab.
2bcbe6b works fine, so the bug was introduced in #16172.

[github-actions]

Hi I'm an AI powered bot that finds similar issues based off the issue title.

Please view the issues below to see if they solve your problem, and if the issue describes your problem please consider closing this one and thumbs upping the other issue to help us prioritize it. Thank you!

Open similar issues:

• Bug with "Open windows from a previous session" and defaults profile run as admin (#14932), similarity score: 0.76

Closed similar issues:

• "Open windows from a previous session" executes even if a window is open. (#16732), similarity score: 0.78
• Open windows from a previous session does not restore the working directories of any tab (#15975), similarity score: 0.76
• Windows Terminal session restore is not remembering the last directory that was set in each tab (#14386), similarity score: 0.76

Note: You can give me feedback by thumbs upping or thumbs downing this comment.

[krzysdz]

The session is correctly restored if an older version (2bcbe6b) is closed and opened in the latest one (67ae9f6), so the problem is with saving session on close.

[lhecker]

I apologize for the issue. We're currently hoping to fix this with #16914.

In the meantime you can hotfix it by commenting out these lines:

terminal/src/cascadia/TerminalApp/TerminalTab.cpp

Lines 461 to 470 in 67ae9f6

	if (const auto& settings{ _rootPane->GetContent().try_as<SettingsPaneContent>() })
	{
	ActionAndArgs action;
	action.Action(ShortcutAction::OpenSettings);
	OpenSettingsArgs args{ SettingsTarget::SettingsUI };
	action.Args(args);
	state.args = std::vector{ std::move(action) };
	}
	else

The issue occurs because SettingsPaneContent is not a proper, projected WinRT class (it doesn't have a definition in an .idl file). Due to this, the try_as call fails. try_as calls QueryInterface and without a projection, SettingsPaneContent doesn't get an IID (interface ID). I checked and with cppwinrt there doesn't seem to be any way around defining it in an .idl file.

[krzysdz]

I've just built from dc4026d (#16914) and session restore works fine.